Re: Please check open Merge Requests before your next upload
Hello,
> If I am understanding this email correctly, it sounds to me like you
> are saying that this is a "code dump" because I didn't email you first.
It's different for every maintainer.
However by default salsa will not send an email when you create a MR,
and I personally (like many others I suspect) never open the salsa
website. I just give git commands. So unless you email me I have
absolutely no idea you opened that MR. It might be a good contribution
that I'd love to accept, I just don't know it's there. And many people
have a lot of packages so they won't go and open salsa and check stuff
for each and every one of them, because it's too time consuming. So I
suspect that most maintainers leave salsa with the default and will
not know a MR exists.
The code dump problem is different, that depends on the specific
contribution. In general on Debian I'd reject large patches I don't
fully understand or if I am not sure on how to make sure nothing else
breaks, or that change behaviour and will affect other users, or many
other reasons.
I've had people get mad at me for rejecting their changes (that
introduced more issues than they solved) because they felt it was my
duty to accept them after they had put in that time. Had they emailed
first, or even read the README and CONTRIBUTING files, it probably
would have everyone involved less sour.
Best
--
Salvo Tomaselli
I difensori della morale tradizionale sono raramente persone di cuore. Si è
tentati di pensare che essi si servano della morale come di legittimo sfogo
al loro desiderio di fare del male agli altri.
-- Bertrand Russell, Perché non sono cristiano. 1957
http://ltworf.github.io/
Reply to: