[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please check open Merge Requests before your next upload



On Fri, Aug 15, 2025 at 07:20:29AM +0200, Ansgar 🙀 wrote:
On Fri, 2025-08-15 at 00:23 +0200, Antoine Le Gonidec wrote:
Opening an MR without having contacted me *prior to the fact* is the
definition of a code dump. I do not care about code, I can very well
write it myself in the first place.
[...]
If sending an e-mail is too much for them, well, too bad, they were not
all that interested in improving the package in the first place to stop
at such a trivial requirement.

A principled opposition to apply patches or fix issues because the
author did not jump to an arbitrary set of hoops set up by a maintainer
seems like a bad idea. Enough security issues were not fixed or only
fixed much later because vendors insisted on such things.

I agree with Ansgar here and would like to ask Antoine if he also ignores MRs that have a friendly and verbose explanation in the MR comment or in the commit messages.

There is more than one way to do it, it's a matter of style, and noone shouold expect other people to do it exactly in the style of the other side. I have seen MR submitters who scold repo owners for having their own workflow (in good faith!), and I have seen a repo owner who flat out says to ignore MRs completely if the submitter does not mit birds and bees inside an out-of-band message.

I think that both approaches are not as good as we could do.

Greetings
Marc

--
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Leimen, Germany    |  lose things."    Winona Ryder | Fon: *49 6224 1600402
Nordisch by Nature |  How to make an American Quilt | Fax: *49 6224 1600421


Reply to: