[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Uploading of libjpeg-turbo 2.0.x to unstable

Hi,
TL;DR; porters' help needed to fix libjpeg-turbo unit tests on sparc64 and powerpc. Thanks! 

On  Di 14 Jan 2020 08:35:34 CET, Mike Gabriel wrote:


Hi all,
(as an unregular reader of debian-devel, please Cc: me so that I don't miss your replies)
I have uploaded libjpeg-turbo 2.0.x to experimental several months ago (August 2019). I feel, it is time to get 2.0.x into testing/unstable now.
However, I have never really done a transition of such a core'ish shared library package and I'd love to receive some guidance with this before I do the actual upload.
First of all, I don't think that a classical transition is required as there has not been an SONAME change for the shared libs in libjpeg-turbo. Package names haven't changed, either.
Simply uploading and waiting for things to break (at runtime) is neither a good approach, I sense. I have done some usual smoke tests (running this and that desktop environment, viewing JPEG images, etc.), but that feels insufficient.
People experienced with transitions of core packages with libjpeg testings, how would you approach sanity checks of libjpeg-turbo 2.0.x before uploading? 
https://salsa.debian.org/debian/libjpeg-turbo

Thanks in advance for any kind of input,
Mike


I forgot to mention more aspects...
First of all, libjpeg-turbo has unit tests and they are being tested at buildtime. The packages does not have autopktests, though. 

Regarding the unit tests...
The whole 2.0.x series failed on two non-official Debian archs during unit tests: 
https://buildd.debian.org/status/package.php?p=libjpeg-turbo&suite=experimental
Tests have been failing on sparc64 [1] and powerpc [2] since the first 2.0.x upload. 

Weird FTBFS occuring since the last upload (2.0.4-1~exp1)...
The today uploaded libjpeg-turbo 2.0.4-1~exp1 upload fails on more architectures (arm64, armhf, so far, builds are still being executed/pending): 

```
-- The C compiler identification is GNU 9.2.1
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- broken
CMake Error at /usr/share/cmake-3.15/Modules/CMakeTestCCompiler.cmake:60 (message): 
  The C compiler

    "/usr/bin/cc"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /<<PKGBUILDDIR>>/obj-aarch64-linux-gnu/CMakeFiles/CMakeTmp
Run Build Command(s):/usr/bin/make cmTC_859bb/fast && make[2]: Entering directory '/<<PKGBUILDDIR>>/obj-aarch64-linux-gnu/CMakeFiles/CMakeTmp' /usr/bin/make -f CMakeFiles/cmTC_859bb.dir/build.make CMakeFiles/cmTC_859bb.dir/build make[3]: Entering directory '/<<PKGBUILDDIR>>/obj-aarch64-linux-gnu/CMakeFiles/CMakeTmp' 
    Building C object CMakeFiles/cmTC_859bb.dir/testCCompiler.c.o
/usr/bin/cc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -ffloat-store -Wdate-time -D_FORTIFY_SOURCE=2 -o CMakeFiles/cmTC_859bb.dir/testCCompiler.c.o -c /<<PKGBUILDDIR>>/obj-aarch64-linux-gnu/CMakeFiles/CMakeTmp/testCCompiler.c 
    Linking C executable cmTC_859bb
/usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_859bb.dir/link.txt --verbose=1 /usr/bin/cc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -ffloat-store -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -rdynamic CMakeFiles/cmTC_859bb.dir/testCCompiler.c.o -o cmTC_859bb 
    collect2: fatal error: ld terminated with signal 4 [Illegal instruction]
    compilation terminated.
    make[3]: *** [CMakeFiles/cmTC_859bb.dir/build.make:87: cmTC_859bb] Error 1
    make[3]: *** Deleting file 'cmTC_859bb'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-aarch64-linux-gnu/CMakeFiles/CMakeTmp' 
    make[2]: *** [Makefile:121: cmTC_859bb/fast] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/obj-aarch64-linux-gnu/CMakeFiles/CMakeTmp' 

```

-> this feels like an issue not related to libjpeg-turbo...

Greets,
Mike

[1] https://buildd.debian.org/status/logs.php?pkg=libjpeg-turbo&arch=sparc64
[2] https://buildd.debian.org/status/logs.php?pkg=libjpeg-turbo&arch=powerpc
--

mike gabriel aka sunweaver (Debian Developer)
mobile: +49 (1520) 1976 148
landline: +49 (4351) 486 14 27

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: sunweaver@debian.org, http://sunweavers.net

Attachment: pgpJPJEilJbEv.pgp
Description: Digitale PGP-Signatur

Reply to: