Re: Comma in Maintainer field (Was: problems in gjots2 and Debian)
Hi again,
for sure I also here forgot the restriction to release='sid'...
On Thu, Apr 19, 2018 at 09:49:34AM +0200, Michael Biebl wrote:
> Am 19.04.2018 um 08:37 schrieb Andreas Tille:
> > On Wed, Apr 18, 2018 at 09:52:18PM +0500, Andrey Rahmatullin wrote:
> >> On Wed, Apr 18, 2018 at 04:00:51PM +0100, Ian Jackson wrote:
> >>> Instead, tools grew to tolerate commas here rather than treat them as
> >>> separators (because they would mishandle the erroneous packages).
> >> Is this the main problem with fixing the Policy? Does someone have a plan
> >> with this?
> >
> > I checked UDD for real cases:
> >
> > udd=# select distinct maintainer from packages where maintainer like '%,%' order by maintainer;
> > maintainer
> > --------------------------------------------------------------------------------------------------------------
> > "Adam C. Powell, IV" <hazelsct@debian.org>
> > Adam C. Powell, IV <hazelsct@debian.org>
> > Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>, Sebastian Dröge <slomo@debian.org>
> > John H. Robinson, IV <jaqque@debian.org>
> > "Natural Language Processing, Japanese" <pkg-nlp-ja-devel@lists.alioth.debian.org>
> > Natural Language Processing, Japanese <pkg-nlp-ja-devel@lists.alioth.debian.org>
> > Rogério Brito <rbrito@ime.usp.br>, +
> > Holger Levsen <holger@debian.org>
> > Thomas Bushnell, BSG <tb@debian.org>
> > TransNexus, Inc. <support@transnexus.com>
> > (9 rows)
> >
> >>From my understanding the names in quotes should be parsed correctly, right?
D> >
> > This leaves 7 maintainer names
> >
> > udd=# select distinct maintainer from packages where maintainer like '%,%' and maintainer not like '"%' order by maintainer;
> > maintainer
> > ---------------------------------------------------------------------------------------------------------------
> > Adam C. Powell, IV <hazelsct@debian.org>
> > Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>, Sebastian Dröge <slomo@debian.org>
> > John H. Robinson, IV <jaqque@debian.org>
> > Natural Language Processing, Japanese <pkg-nlp-ja-devel@lists.alioth.debian.org>
> > Rogério Brito <rbrito@ime.usp.br>, +
> > Holger Levsen <holger@debian.org>
> > Thomas Bushnell, BSG <tb@debian.org>
> > TransNexus, Inc. <support@transnexus.com>
> > (7 rows)
Here comes a better query with those issues that require some action:
udd=# select distinct release, maintainer from packages where (release in ('sid', 'experimental') or release like '%backports') and maintainer like '%,%' order by maintainer;
release | maintainer
------------------+------------------------------------------------------------------------------------
sid | Adam C. Powell, IV <hazelsct@debian.org>
sid | "Natural Language Processing, Japanese" <pkg-nlp-ja-devel@lists.alioth.debian.org>
sid | Natural Language Processing, Japanese <pkg-nlp-ja-devel@lists.alioth.debian.org>
jessie-backports | Rogério Brito <rbrito@ime.usp.br>, +
| Holger Levsen <holger@debian.org>
(4 rows)
BTW, I remember Adam C. Powell, IV was very active in Debian Science but
I havn't seen any upload from him any more. I've put him in CC - may be
that's a case for the MIA team but I'll wait for a response.
My question, whether quoted names with comma inside is valid remains.
> > Out of these there are clearly two bugs that violate our current
> >
> > udd=# select distinct package, maintainer from packages where maintainer like '%>%,%'order by maintainer;
> > package | maintainer
> > ------------------+---------------------------------------------------------------------------------------------------------------
> > gir1.0-gdata-0.0 | Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>, Sebastian Dröge <slomo@debian.org>
> > libgdata7 | Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>, Sebastian Dröge <slomo@debian.org>
> > libgdata-common | Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>, Sebastian Dröge <slomo@debian.org>
> > libgdata-dev | Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>, Sebastian Dröge <slomo@debian.org>
> > libgdata-doc | Debian GNOME Maintainers <pkg-gnome-maintainers@lists.alioth.debian.org>, Sebastian Dröge <slomo@debian.org>
> > youtube-dl | Rogério Brito <rbrito@ime.usp.br>, +
> > | Holger Levsen <holger@debian.org>
> > (6 rows)
That's in fact basically done in sid (and all other relevant
architectures until oldstable):
udd=# select distinct package, maintainer from packages where (release in (select release from releases where role != '') or release like '%backports') and maintainer like '%>%,%' order by maintainer;
package | maintainer
------------+-------------------------------------
youtube-dl | Rogério Brito <rbrito@ime.usp.br>,+
| Holger Levsen <holger@debian.org>
(1 row)
I've just noticed a mail on debian-backports list clarifying this.
> > I think we should start filing bug reports against packages
> > that do not match our current understanding of that field
> > (and lintian should throw an error about this).
> >
> > Currently that definitely fits the last query but if we
> > intend to enhance the maintainer field to some later point
> > in time we should also ask the other 5 maintainers above
> > to add quotes around their names.
> >
> > What do you think?
>
> libgdata seems to be a false positive. before filing bug reports, please
> restrict that search to sid (libgdata7 is from 2011)
Thanks for the hint. On the other hand: As long as those Maintainer
strings are in a relevant release in UDD we should be carefull with
changing the code dealing with the maintainer field:
udd=# select array_agg(release), maintainer from (select distinct release, maintainer from packages where (release in (select release from releases where role != '') or release like '%backports') and maintainer like '%,%') tmp group by maintainer order by maintainer;
array_agg | maintainer
-----------------------------+------------------------------------------------------------------------------------
{sid,stretch,jessie,buster} | Adam C. Powell, IV <hazelsct@debian.org>
{stretch,sid,jessie,buster} | "Natural Language Processing, Japanese" <pkg-nlp-ja-devel@lists.alioth.debian.org>
{sid,buster,jessie,stretch} | Natural Language Processing, Japanese <pkg-nlp-ja-devel@lists.alioth.debian.org>
{jessie-backports} | Rogério Brito <rbrito@ime.usp.br>, +
| Holger Levsen <holger@debian.org>
{jessie,stretch} | Thomas Bushnell, BSG <tb@debian.org>
{jessie} | TransNexus, Inc. <support@transnexus.com>
(6 rows)
Thanks to all who proactively changed the Maintainer field in sid
Andreas.
--
http://fam-tille.de
Reply to: