[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: new default build flag from dpkg: -Wdate-time



On Thu, Nov 12, 2015 at 06:46:37PM +0100, Georges Khaznadar wrote:
> Mattia Rizzolo a écrit :
> > From our builds, we can only see 4 packages which fail to build due to
> > this: [...]
> >     expeyes
> >         https://bugs.debian.org/790103
> 
> The reason why expeyes FTBFS, is that the flag -Wdate-time is applied to
> a call of avr-gcc, which is based on gcc-4.8, and ignores this flag.

ok, this would also be interesting to be forwarded on that bug, though.
I bounced the mail to the bug and added it to CC here

> So I can imagine a few workarounds:
> 1- some trick to prevent the use of -Wdate-time when it touches avr-gcc

no, please, no need to be so dirt :)

> 2- isolate the patch which introduced the new flag into gcc-4.8 and apply
>    it to make a new release of the package gcc-avr_1:4.8.1+Atmel3

sounds wrong...

> 3- rebase the package gcc-avr on a newer version of gcc, which may be a
>    hard work. Such a work seems to exist, for example at
>    https://www.archlinux.org/packages/community/x86_64/avr-gcc/ since
>    last July

This is what should be done, really.

> I may try the first workaround, just replacing manually $(CFLAGS) by
> a hardwired option chain in the Makefile which calls avr-gcc.

No need, remember that the default compiling flags are entirely
overridable at build time, see dpkg-buildflags(1).
This is anyway not really needed *right now* (unless you'd like to see
your package built in our CI), it'll be really needed once dpkg
incorporate it.

> The second and the third workarounds should imply Hakan Ardo, who
> maintains the package gcc-avr. The last one sounds like a good fix
> rather than a mere workaround.

Maybe this is something (also) upstream should look at.

> Which is your opinion about this?

If everybody agrees on having avr-gcc deal with the whole CPPFLAGS is
what it's supposed to do, then this bug should be reassigned to it, and
a "affects" link be left.
If this flag will be added before avr-gcc gets fixed, simply disabling
reproducible/timeless is the best way forward.
IMHO.


-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  http://mapreri.org                              : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


Reply to: