Re: Help to review a patch in ELisp
Stéphane Aulery wrote:
> I am looking for a person who knows enough to verify a ELisp patch. The
> patch is supposed to fix a problem of space in file names [1], upstream
> unfortunately does not have the in-house expertise [2].
[...]
> diff -r -u cscope-15.7a/contrib/xcscope/cscope-indexer change/cscope-15.7a/contrib/xcscope/cscope-indexer
> --- cscope-15.7a/contrib/xcscope/cscope-indexer 2001-06-28 12:39:48.000000000 +0800
> +++ change/cscope-15.7a/contrib/xcscope/cscope-indexer 2010-04-28 17:46:02.000000000 +0800
> @@ -139,7 +139,8 @@
> ) | \
> egrep -i '\.([chly](xx|pp)*|cc|hh)$' | \
> sed -e '/\/CVS\//d' -e '/\/RCS\//d' -e 's/^\.\///' | \
> - sort > $LIST_FILE
> + sort | \
> + sed -e 's/.* .*/\"&\"/' > $LIST_FILE
>
> if [ "X$VERBOSE" != "X" ]
> then
I can't speak for the rest of the patch without digging into quite a bit
of the context and assumptions in the elisp, but regarding this bit,
rather than checking for spaces and only quoting filenames then, just
*always* quote all filenames. That also makes sure you test that path
thoroughly.
- Josh Triplett
Reply to: