[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#758231: rsyslog: is priority important, depends on packages with priority extra



On Fri, Aug 15, 2014 at 06:51:44PM +0200, Bill Allombert wrote:
> Please do not report RC bug for this. Priorities are adjusted by the FTP master
> team by batch using the overrides file. There is no need to report bugs against
> the packages.

Hi, I filed three bugs for the extreme, where priority required depends
on priority extra in current jessie.  No fear, I won't do mass filing.

I queried all the numbers on this beforehand.  And I don't think it's
good to solve all this through ftp master's override[0].  This will
bloat the installations using high priority packages more and more.

In stable we have the following violations (packages)
 important: 8
 required: 2
 standard: 21
In current testing:
 important: 15
 required: 5
 standard: 43

It's not hundreds, or thousands.  Keep cool.
rsyslog was fine when we raised its priority in wheezy.

I personally don't care that much about the standard priority, but for
the higher ones, and definitely think we should stop this trend before
it's too late.

You can play with the tiny dash script attached, it was fun to write
it, call
 ./check-prio required
 ./check-prio required important
 ./check-prio required important standard

Regards, Gerrit.

[0] current signs are that this will pull perl into the required
packages set:
http://lists.alioth.debian.org/pipermail/pkg-systemd-maintainers/2014-August/thread.html#3161
#!/bin/sh
set -e

priorities=${*:=required important standard optional}

aptitudeprios=$(for i in $priorities; do echo ~p$i\ ; done)
aptitude search $aptitudeprios -F%p | sed -e's/^ *//;s/ *$//' |
while read package; do
  depends=$(apt-cache show $package |grep '^Depends: ' || :)
  depends=${depends#Depends: }
  buggy=; broken=
  IFS=,
  for dep in $depends; do
    dep=${dep%%| *}
    dep=${dep##[ *]}; dep=${dep%%[ *]}
    dep=${dep%% (*)}; dep=${dep%%\[*\]}; dep=${dep%% (*)}
    prio=$(apt-cache show $dep |grep '^Priority: ' |head -n1)
    test -n "$prio" ||
      { echo \ warning: $package: depends $dep: no priority; continue; }
    prio=${prio#Priority: }
    broken=yes
    IFS=\ 
    for i in $priorities; do
      test "$prio" != "$i" || broken=
    done
    test -z "$broken" ||
      { echo \ broken: $package: depends $dep, priority $prio.; buggy=yes; }
  done
  test -z "$buggy" || echo buggy: $package
done

Reply to: