[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: screen says "Bad tty" if /dev/console is a symlink

On Sun, 2013-01-27 at 16:20:25 +0000, Roger Leigh wrote:
> Given the amount of work already done by the Hurd porters, would
> it be viable to undef PATH_MAX and do a test build to look at how
> much this breaks?  The other advantage is that it reduces duplicate
> codepaths in all the places where we have #ifdef PATH_MAX
> (where the dynamic allocation is done only for Hurd, rather than
> across the board).  This alone would remove a whole bunch of
> potential bugs and improve the overall code quality and robustness.

While wearing my GNU/Hurd porter hat, I've always advocated to try to
fix MAX issues unconditionally, sometimes upstreams might prefer
different code paths though.

But yes, doing such mass build would be very useful to see how many are
still there. I'd also be in favor of removing MAX defines from all our
currently supported architectures.

Although such build would not find all MAX instances, as some upstreams
define those to arbitrary values if they are not defined.


Reply to: