[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Ok to use upstream doumentation as-is (i.e. not regenerate)?



On 11-06-07 at 12:54pm, Vincent Danjean wrote:
> On 05/06/2011 07:39, Vincent Bernat wrote:
> > On Sat, 4 Jun 2011 21:54:11 +0200, Jonas Smedegaard wrote:
> > 
> >> What I do is use upstream provided tarballs, then put aside 
> >> autotools-generated files, then autogenerate myself, and in the 
> >> clean rule put back the upstream-provided files (because I want not 
> >> only minimal required build routines idempotent but also building 
> >> with git-buildpackage).
> > 
> > In the clean rules, you can just delete those autogenerated files.
> 
> If you do not want git-buildpackage to complain (of
> "not committed changes"), you need to restore them.
> 
> I often use this in my rules:
> clean:
> 	[...]
>         # if this is a git repository, restore removed files that would have
>         # been ignored by dpkg-source
>         -test -d .git && git checkout -- $$(git status | \
>                 sed -e '/^#[[:space:]]*deleted:[[:space:]]*/s/^#[[:space:]]*deleted:[[:space:]]*//p;d' | \
>                 grep -v '^debian/')

I strongly believe Debian packaging rules should always behave the same 
- at least the main rules required by Debian Policy.

Therefore I dislike patterns like above, which behaves different based 
on the presence of some files in source during build!


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Attachment: signature.asc
Description: Digital signature


Reply to: