[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFH: bashisms in configure script



On mercredi 26 mai 2010 02:39:52 Raphael Geissert wrote:
[SNIP]
> 
> Yes, $BASH_SOMETHING is just used to make it easier to see that the
> following code (probably a bashism) is only executed after checking the
> shell is actually bash. That and the other FP are the most common ones, yet
> not that easy to fix (the latter, of course, the former is not a FP.)
> 
> > I'm seeing only these for gxine, xine-lib and xine-ui, which is slightly
> > odd because testing with dash has shown up an actual bashism in
> > xine-lib's configure.ac (which I've just fixed upstream): use of "test x
> > == y".
> 
> Could you please send me by email the files with false negatives? those are
> very likely bugs in checkbashisms' quotes handling code.

Among other false positive there is warning about scripts removed in clean 
target of debian/rules.

Anyway, thanks for the massive run of checkbashism, it made me discover a few 
bashism in 2 upstream scripts in my packages.
> 
> Thanks.
> 
> Cheers,

Best regards

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: