Re: New source package formats now available
On Mon, 23 Nov 2009, Goswin von Brederlow wrote:
> > Well, they can drop the patch in debian/patches, and add it to
> > the end of debian/patches/series. If quilt is installed, it should
> > work as dpkg-source will use quilt applied to know
> > whether patches needs to be applied. If quilt is not installed, it assumes
> > all patches are applied, so you should also apply the patch.
>
> Are you sure about that?
Yes.
> dpkg creates a debian/patches/dpkg-applied-patches file listing the
> patches it has applied. It should notice when the series file has more
> patches than were applied and remedy the situation.
It was partly the goal when I created this file but it simply creates
more problems than it solves. You can't be sure that this file really
corresponds to the current state of the tree, it's created at unpack time
but it's not maintained over time when you rebuild.
In the end, I decided to trust nothing and to verify if the first
patch can be applied or not. If it can be applied, we assume that the
patches have not been applied and we apply them all (unless
--no-preparation is given). If quilt is available, instead of checking the
first patch, I check the first patch returned by quilt unapplied
and apply the remaining of the patches if needed.
Cheers,
--
Raphaël Hertzog
Reply to: