[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Switching /bin/sh to dash (part two)



Clint Adams <schizo@debian.org> wrote:
[...]
> The second hunk isn't relevant to bash, but it seems a waste to
> call ls and head for no reason.

> --- debian/libpam0g.postinst.orig       2009-07-24 08:59:07.000000000 -0500
> +++ debian/libpam0g.postinst    2009-07-24 09:00:38.000000000 -0500
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/bin/sh

> # postinst based heavily on the postinst of libssl0.9.8, courtesy of 
> # Christoph Martin.
> @@ -73,7 +73,7 @@

>     for service in $check; do
>        if [ -x "`which invoke-rc.d 2>/dev/null`" ]; then
> -          idl=$(ls /etc/init.d/${service} 2> /dev/null | head -n 1)
> +          idl="/etc/init.d/${service}"
>           if [ -n "$idl" ] && [ -x $idl ]; then
>                services="$service $services"
>           else


Hello,

FWIW the $(...) construct is not a bashism.
cu andreas
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'


Reply to: