Hi Dne Fri, 16 May 2008 20:59:44 +0200 Martin Uecker <muecker@gmx.de> napsal(a): > I don't see a patch there. This might sound like nitpicking, but > a real patch would have provided some context to the two lines. Yes there is no context, but it is patch and it is clear that it wants to remove two lines of code. Today all we know that only one of them was relevant to that problem... > Nevertheless, the right thing in my opinion would have been to > propose a patch, wait until it is accepted, and then to package > the new upstream version. Well the problem is that you always don't get response, you simply have to include some patches before they are reviewed/accepted by upstream. If you're lucky, upstream is responsive and you can push all patches directly to them, but from my experience[*] it many times does not work. [*]: I don't have much patched my Debian packages (well I'm upstream for many of them), but I was working for SUSE about 3 years ago and many of patches which were really needed for packaging are still waiting for even review in upstream trackers. You simply can not build distribution without not reviewed patches. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Attachment:
signature.asc
Description: PGP signature