[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Getting rid of circular dependencies, stage 4



On Wed, May 10, 2006 at 01:41:56PM -0400, Hubert Chan wrote:
> On Wed, 10 May 2006 09:04:14 -0400, James Vega <jamessan@jamessan.com> said:
> 
> > On Wed, May 10, 2006 at 12:32:53AM -0400, Hubert Chan wrote:
> >> Hmm...  alsaplayer-common Depends: on "alsaplayer-alsa |
> >> alsaplayer-output" and "alsaplayer-gtk | alsaplayer-interface".  Is
> >> this really a problem?
> 
> My question, which I guess wasn't clear, was whether the circular
> dependency is still a problem if one of the dependencies in the cycle is
> an or'ed dependency.

As far as I know, yes, they are still a problem.

> [...]
> 
> > There's no real reason that alsaplayer-common needs to Depend on an
> > alsaplayer-output variant or an alsaplayer-interface variant.  As a
> > user, if I just want to look at the common files for some reason, I
> > sholudn't need to install alsaplayer-(output|gtk).  Those would be
> > fine as Recommends.
> 
> alsaplayer-common contains the main alsaplayer binary
> (/usr/bin/alsaplayer), which does not function without an
> alsaplayer-output and alsaplayer-input plugin.  So yes, it really does
> depend on these.  (I would have named alsaplayer-common something
> different -- maybe alsaplayer-bin, or just alsaplayer, but that was what
> it was called when I inherited it.)

Ah, yes, I didn't take a look at the packages as well as I should have.
Taking a look at the package contents, it seems like changing the
alsaplayer-(output|input) variants to Recommending alsaplayer-common
would work fine.

James
-- 
GPG Key: 1024D/61326D40 2003-09-02 James Vega <jamessan@jamessan.com>

Attachment: signature.asc
Description: Digital signature


Reply to: