[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Building in chroots hides bugs? (was: Successful and unsuccessful Debian development tools)

* martin f krafft <madduck@debian.org> [060801 18:17]:
> also sprach Bernhard R. Link <brlink@debian.org> [2006.08.01.1701 +0100]:
> > Missing $(DESTDIR)s in Makefiles are an example. Especially when the
> > install part was DESTDIRified, but the test before if the file is
> > already there (as make install does not want to overwrite a config file)
> > was forgotten.
> > This leads to a corrupt package when build on a system where the package
> > is already installed, i.e. is hidden away in any clean chroot.
> This makes zero sense to me.

Consider (in Makefile.in):

install: [...]
        -if [ ! -f $(sysconfdir)/Bla ]; then \
          $(INSTALL) -m644 $(srcdir)/Bla $(DESTDIR)$(sysconfdir)/Bla \

This is clearly a bug, most likely someone added DESTDIR later and
forgot it in the test. But unless that package build depends on itself,
you will never find it when building in a clean chroot.
  Bernhard R. Link

Reply to: