Re: rules: unpatch as dependency (was Bug#351301)

[Junichi Uekawa <dancer@netfort.gr.jp>]

Hi,

> > Jörg Sommer wrote:
> > >  # prep-deb-files from module-assistant creates the neccessary debian/ files 
> > > -kdist_config: prep-deb-files
> > > +kdist_config: prep-deb-files patch-stamp
> > 
> > Not needed. The patches are in -source already pre-applied.
> > 
> > > +	-$(MAKE) -f debian/rules unpatch
> > 
> > or a dependency on unpatch.
> 
> A good point. I've a package with a library that does not support
> libtool. Because libtool saves files to special places it needs to be
> called for cleanup, too.
> 
> If I set unpatch as dependency for the clean target all patches get
> removed before I can call make clean. Thus I have no way to patch the
> clean target of upstream makefiles. The idea I had was to call the
> unpatch target after I've run make clean. Do you have a better idea?

It's actually not required to have 'clean' do 'unpatch'.  You can have
diff.gz contain the patched version, so that a simple 'dpkg-source -x'
will extract the fully patched version.

You just need to make sure you have unpatch/patch sequence somewhere
in your build (or configure) target, and make sure you use
dpatch-edit-patch or other tools when modifying source.



regards,
	junichi
-- 
dancer@{debian.org,netfort.gr.jp}   Debian Project