[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [SM-DEVEL] broken attachments with multiple attachments and php 4.3.11



Hello Roalt,

On Fri, June 3, 2005 11:37, Roalt Zijlstra wrote:
> I think I have fix for this silly PHP 4.3.11 bug and the fix is even more
> trivial. I can't imagine this will break anything.

Thanks! It looks indeed ok, I'll mail it to the -devel list to get some
more eyes on it, and will commit it shortly unless concerns arise. I think
it will go into the 1.4.5 release.

Unfortunately this can't get into Debian anymore (so that will have the
bad PHP-version and the not-worked-around SquirrelMail version) because
Sarge will be released on Monday.


Thijs

> Here is the patch:
> --- Deliver.class.php.orig      2005-06-03 11:21:38.000000000 +0200
> +++ Deliver.class.php   2005-06-03 11:16:34.000000000 +0200
> @@ -168,6 +168,11 @@
>                  $encoded = '';
>                  while ($tmp = fread($file, 570)) {
>                     $body_part = chunk_split(base64_encode($tmp));
> +                   /* Up to 4.3.10 chunk_split always appends a newline,
> while in 4.3.11 it doesn't if
> +                    * the string to split is shorter than the chunk
> length.
> +                    */
> +                   if( substr($body_part, -1 , 1 ) != "\n" )
> +                       $body_part .= "\n";
>                      $length += $this->clean_crlf($body_part);
>                      if ($stream) {
>                          $this->writeToStream($stream, $body_part);
>
> Sweet and simple and works for all PHP versions which were backpatched
> like
> the Debian PHP 4.3.10.
>
> Greetings,
>
> Roalt
> --
> Project-Based Calendar System
> http://www.pbcs.org
> roalt@pbcs.org
> roalt@kwenie.org
> zijlstra@stone-it.com (Work)
>
>




Reply to: