[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Base frozen but setserial is no longer a part of it.



On Mon, Aug 23, 2004 at 12:52:47PM +0200, Ola Lundqvist wrote:
> On Mon, Aug 23, 2004 at 11:25:38AM +0100, Colin Watson wrote:
> > On Mon, Aug 23, 2004 at 10:57:34AM +0200, Ola Lundqvist wrote:
> > > http://qa.debian.org/developer.php?excuse=setserial
> > > 
> > > According to that page, setserial is frozen. I assume that this
> > > is a mistake as it was removed from base just a few weeks ago.
> > > 
> > > Is this true and who knows more?
> > 
> > setserial was removed from base in debootstrap 0.2.41. However,
> > debootstrap-udeb (which is used in debian-installer) is only at version
> > 0.2.40 in testing.
> 
> Ahh I see. Then I assume that I have to upload setserial to
> proposed updates, then. Or can someone force it to testing?

I can. Reviewing the diff, though, I find this mistake in
debian/postinst:

-       if [ "$ANSWER" = "no" -o "$ANSWER" = "NO" -o "$answer" = "n" -o "$ANSWER" = "N" ]
+       if [ "$ANSWER" = "no" || "$ANSWER" = "NO" || "$answer" = "n" || "$ANSWER" = "N" ]

I think you meant:

        if [ "$ANSWER" = "no" ] || [ "$ANSWER" = "NO" ] || [ "$answer" = "n" ] || [ "$ANSWER" = "N" ]

You added a foo.txt to the source package which looks like removable
cruft.

debian/po/nl.po has stray Ctrl-M characters all over the place.

If you'll fix these, I'll approve it for testing.

Cheers,

-- 
Colin Watson                                  [cjwatson@flatline.org.uk]



Reply to: