[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: debsums for maintainer scripts

Michael Ablassmeier wrote:
> IMHO Lintian should also check if "dh_md5sums" is called and
> print at least a warning if this is not the case.
In principle, I argree, but maybe it's better to check for the presence
of an md5sums file than to "force" (haha) people who don't like it to do
Attached is a linda patch that does that. Maybe I'll post a link the
result of the run on my mirror later.


diff -urN linda-0.2.23~/checks/controlfiles.py linda-0.2.23+/checks/controlfiles.py
--- linda-0.2.23~/checks/controlfiles.py	2003-09-23 10:19:19.000000000 +0200
+++ linda-0.2.23+/checks/controlfiles.py	2003-12-01 20:15:06.000000000 +0100
@@ -10,6 +10,8 @@
         norm_control = ('control', 'md5sums', 'conffiles', 'templates', \
         control_files = exec_control + norm_control
+	if not common.control_info.has_key('md5sums'):
+	    self.signal_error('no-md5sums-control-file')
         for k in common.control_info.keys():
             if k not in control_files:
                 self.signal_error('unknown-control-file', [k])
diff -urN linda-0.2.23~/desc/controlfiles.desc linda-0.2.23+/desc/controlfiles.desc
--- linda-0.2.23~/desc/controlfiles.desc	2003-09-23 10:19:21.000000000 +0200
+++ linda-0.2.23+/desc/controlfiles.desc	2003-12-01 20:11:42.000000000 +0100
@@ -101,3 +101,10 @@
  The maintainer script shown above calls update-rc.d the number of times
  listed above. 
+Tag: no-md5sums-control-file
+Type: Warning
+_Description: Package has no md5sums control file.
+ The package does not have a md5sums control file which can be
+ used to verify the integrity of installed package's file via
+ debsums. md5sums files can be created with dh_md5sums.

Attachment: pgp1V1vZ2Zy0R.pgp
Description: PGP signature

Reply to: