[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: serious bug. Evolution and Microsoft mentality.



Jonathan Walther <krooger@debian.org> writes:
> Jeffrey Stedfast wrote:

>> Oops, copy/paste-o when migrating the patch to the 1-0 code base.
> 
> Here is the correct patch for the 1.0.x branch.  Hopefully the Debian
> maintainer will apply it?  I am creating an Evolution 1.0-5.1 package
> on my system with the patch applied.  I haven't seen so many signal 11's
> in aeons.
> 
[...]
> +	
> +	/* follow any symlinks to the mailbox */
> +	  memset(folder_path, 0, sizeof folder_path);
> +	  if (lstat (lf->folder_path, &st) != -1 && S_ISLNK (st.st_mode) &&
> +	      realpath (lf->folder_path, folder_path) != NULL) {
> +	  	g_free (lf->folder_path);
> +		lf->folder_path = g_strdup (folder_path);
> +	  }

This code silently breaks with very long filenames.  As such it can
hardly be considered a "correct patch"!

-- 
http://www.greenend.org.uk/rjk/



Reply to: