Re: serious bug. Evolution and Microsoft mentality.
Oops, copy/paste-o when migrating the patch to the 1-0 code base.
Jeff
On Wed, 2002-01-09 at 19:28, Jonathan Walther wrote:
> Thank you for the patch. To make it work, you need to define the
> variable "folder_path". I would recommend this:
>
> char folder_path[4096];
>
> And then before using it, do this:
>
> memset(folder_path, 0, sizeof folder_path);
>
> Cheers.
>
> Jonathan
>
> On Wed, Jan 09, 2002 at 04:57:34PM -0500, Jeffrey Stedfast wrote:
> >> You solved the problem. That is the correct solution. After running
> >> realpath(), use dirname() and make the tmpfile in the same directory
> >> as the mailbox.
> >>
> >[snip]
> >
> >The attached patch will fix this issue.
> >
> >>
> >> >> Again, provided one uses Maildir mailboxes, things will be fine. But
> >> >> the thought occurs, Evolution should do its "locking" on the file
> >> >> returned from realpath() too.
> >> >
> >> >You are probably right.
> >>
> >> I've thought about it some more, and I'm upgrading my "maybe" to a
> >> strong "this is the proper way to do it". Symlinks should not be
> >> locked. They should be followed with realpath() and the real mailbox
> >> should be locked, like other MUA's do. This will truly make it
> >> compatible and play nicely on the Unix system.
> >
> >It also fixes this.
--
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj@ximian.com - www.ximian.com
Reply to: