[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: BTS really broken

reassign 60935 ftp.debian.org
On Wed, 9 Aug 2000, Joey Hess wrote:

> /etc/debbugs/Maintainers on master has:
> prc-tools            John Goerzen <jgoerzen@complete.org>
> /org/ftp.debian.org/scripts/masterfiles/mkmaintainers{,.pl} on auric seems
> to be what makes this file. The perl script essentially loads up some files
> like pseudo-packages.maintainers, then iterates over all of stable, frozen,
> unstable, and experimental (these are called "suites" for some reason), 
> parses all .dsc files files for maintainer info. Each time it gets a 
> maintainer, it calls this function:

This is not a bug in debbugs, nor the bts, as the creation of
this file is control by dinstall, which is overlooked by the
ftpadmins.  Reassigned to ftp.debian.org.

>  sub setmaint () {
>   my($p, $newm, $newa, $news, $newv) = @_;
>   if (! $maint{$p} ||
>       ($news == $suite{$p} || $news != $DI::dist{'experimental'}{'suite'}) &&
>       ($news > $suite{$p} || newer($newv, $version{$p})) &&
>       (($arch{$p} ne 'any' && $arch{$p} ne 'all') || $newa eq 'any' || $newa eq 
> 'all')) {
>     $maint{$p} = $newm;
>     $arch{$p} = $newa;
>     $suite{$p} = $news;
>     $version{$p} = $newv;
>   }
> }
> Ugh. That if statement really sucks. I think it must be preventing the
> maintainer of a package from being seen if a maintainer was already found 
> earlier, but only in some cases. I haven't entirely puzzled through it yet.

Imho, I'd remove the '! $maint{$p}' part.  This means the first instance of a
package in any file will be saved.  In prc-tools case, this first version is

The real problem here is that dinstall has a notion of separate versions of
debian(slink, potato, woody), but debbugs does not.  When dinstall exports its
data, it does so in an inconsistent way.  This particular script takes the
first instance.  Other scripts take the last instance.

Version: 3.12
GCS d- s: a-- c+++ UL++++ P+ L++++ !E W+ M o+ K- W--- !O M- !V PS--
PE++ Y+ PGP++ t* 5++ X+ tv b+ D++ G e h*! !r z?
Adam Heath <doogie@debian.org>        Finger Print | KeyID
67 01 42 93 CA 37 FB 1E    63 C9 80 1D 08 CF 84 0A | DE656B05 PGP
AD46 C888 F587 F8A3 A6DA  3261 8A2C 7DC2 8BD4 A489 | 8BD4A489 GPG
-----END PGP INFO-----

Reply to: