[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#24930: samba: samba needs to suggest psmisc? (fwd)



Eloy A. Paris wrote:
> please take a look at the following bug I have just received. I thought
> killall is supposed to be present on all Debian systems. Isn't this the
> case anymore?
> 
> If that is the case then I prefer to print a text saying something like
> "run ps ax|grep [sn]mbd" to get the PID's of the nmbd and smbd and the
> kill those processes" rather than "now run killall nmbd and killall smbd".
> 
> I really don't want samba to suggest package psmisc (unless someone gives
> me good reasons for doing so).
G'day Eloy,
  I am the packager of both procps and psmisc, so here's some history.

In the beginning, killall used to belong to the procps package.  Then the
upstream guys, for whatever reason, split the package up into procps and
psmisc.  killall, fuser and pstree got moved to psmisc.  Now procps, I 
think, used to be essential.  Neither procps or psmisc are essential now.

Both packages are in the base section, however procps is required while 
psmisc is optional.  This means that there could be Debian systems that
may not have psmisc.

When the split occurred, there was much noise about what should be done
with *scripts* that use killall.  The consensus was they shouldn't, but if
they do they should have a Depends: or Pre-Depends: on psmisc.  From what
I've seen of scripts with killall in at least Debian's contexts, they were
init.d scripts in which the author was not aware of start-stop-daemon.

OK, there's the history, the rest is pure opinion.

Now from what I can understand from your email the killall here comes from
either documentation or an echo to the screen.  It is not a script, it's 
some a human reads.  IMHO, I do not think it warrants a dependency.  At the
very most, it may need a pointer...
"now run killall nmbd and killall smbd (killall is available in the Debian
psmisc package)".

But really, i think even this is being a bit excessive. If you want to be
even more excessive, then you could use Suggests.  IMHO there is no call
for a dependency.

  - Craig

-- 
Craig Small VK2XLZ, PGP: AD 8D D8 63 6E BF C3 C7  47 41 B1 A2 1F 46 EC 90
|@work: csmall@scooter.o.i.net,            @play: vk2xlz@vk2xlz.ampr.org|
|@home: csmall@small.dropbear.id.au,           @debian:csmall@debian.org|
|@web: http://www.triode.net.au/~csmall             @spam:root@localhost| 


--  
To UNSUBSCRIBE, email to debian-devel-request@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org


Reply to: