Re: suidmanager 0.6 uploaded to master.debian.org

["Karl M. Hegbloom" <karlheg@inetarena.com>]

>>>>> "Christoph" == Christoph Lameter <clameter@waterf.org> writes:

	[... in a release announcement ...]
    Christoph> May fix situations leading to something described in
    Christoph> #9435, #9582 (still not clear how such a thing can
    Christoph> happen).

 This fixes the bug.  With set -e, the grep on line 75 (X=...) causes
the script to abort if the regex is not found in the configuration
file, which is what will happen if it was not already there.
`suidregister` ran fine from a commandline, since 'set -e' is not in
effect then.  But from a postinst, it is.

 I think that maybe 'set -e' should have file scope.

 Here's the patch:
8<----------------------------------------------------------------->8
*** /usr/sbin/suidregister~	Sun Apr 27 12:44:37 1997
--- /usr/sbin/suidregister	Sun May 11 00:01:43 1997
***************
*** 3,8 ****
--- 3,15 ----
  # Register a binary
  #
  
+ if echo $- | grep -q e; then
+   e=-e
+   set +e
+ else
+   e=+e
+ fi
+ 
  function setperm()
  {
  	if [ -e $2 ]; then
***************
*** 80,82 ****
--- 87,91 ----
  
  echo "$PACKAGE $1 $2 $3 $4" >>/etc/suid.conf
  setperm $PACKAGE $1 $2 $3 $4
+ 
+ set $e
8<----------------------------------------------------------------->8

-- 
Karl M. Hegbloom <karlheg@inetarena.com>
http://www.inetarena.com/~karlheg
Portland, OR  USA
Debian GNU 1.2  Linux 2.1.36 AMD K5 PR-133


--
TO UNSUBSCRIBE FROM THIS MAILING LIST: e-mail the word "unsubscribe" to
debian-devel-request@lists.debian.org . 
Trouble?  e-mail to templin@bucknell.edu .