[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFS] GOverlay 0.3.5-1 and MangoHud 0.4.1-1

Hi Stephan,

I just had a look at your MangoHud package (and salsa repository). Here
are my comments.

- The salsa repository does not seem to be based on the tarball found by
uscan, but rather on some preexisting upstream git repository. In
particular, when cloning it, the ImGui directory is missing, because it
is a submodule from GitHub.
Maybe you should consider using git-build-package.
- A man page for mangohud is missing.
- A copyright entry is missing for the following files:
    * modules/ImGui/src/imstb_rectpack.h
    * modules/ImGui/src/imstb_textedit.h
    * modules/ImGui/src/imstb_truetype.h
    * modules/ImGui/src/imgui_draw.cpp
    * modules/ImGui/src/examples/libs/usynergy/uSynergy.h
- The copyright of some fonts does not match the one included in the
file itself:
    * modules/ImGui/src/misc/fonts/DroidSans.ttf
    * modules/ImGui/src/misc/fonts/RobotoMedium.ttf
- The following files have a copyright but no explicit license, which
may make them unredistributable:
    * modules/ImGui/src/examples/example_apple_metal/macOS/Info-macOS.plist
    * modules/ImGui/src/examples/example_marmalade/marmalade_example.mkb
    * modules/ImGui/src/examples/example_marmalade/main.cpp
    * modules/ImGui/src/examples/imgui_impl_marmalade.h
    * modules/ImGui/src/examples/imgui_impl_marmalade.cpp
Since these are mere examples from an embedded library, you might just
exclude them from the upstream tarball.

Once you fix these issues, I will upload the package.

Best regards,
Vincent Prat

Le 23/06/2020 à 10:41, Stephan Lachnit a écrit :
> Hi,
> I'm still searching for a sponsor for GOverlay and MangoHud. I described them both in an earlier mail to debian-devel-games: https://lists.debian.org/debian-devel-games/2020/06/msg00006.html
> Today I uploaded the Debian package for GOverlay 0.3.5 to mentors: https://mentors.debian.net/package/goverlay
> It works perfectly with MangoHud 0.4.1, which needs a sponsor as well: https://mentors.debian.net/package/mangohud
> Please consider uploading them. MangoHud recently got featured on a Linux Gaming video from Linus Tech Tips (a large Mainstream Tech YouTube Channel), but installing MangoHud on Debian based operating systems is still super messy.
> For GOverlay, the upstream author even added install instructions to grab the package from mentors since it hasn't been sponsored in since 2 months: https://github.com/benjamimgois/goverlay/commit/01d0de11417a1bb5b71e94cb49a7ee95508cd17e
> And again I'm still searching for someone (independent of this sponsorship request) who can give me Maintainer access to https://salsa.debian.org/games-team/goverlay since I accidentally locked my self out of it.
> Cheers and thanks in advance,
> Stephan Lachnit

Reply to: