[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Sponsor my 'osmose-emulator' package

Hi Carlos

On Thu, Oct 11, 2018 at 11:37:59PM -0300, Carlos Donizete Froes wrote:
> Hi,
> I have package in 'mentors.d.n' a month ago with some bug fixes
> the previous version of Debian. Could someone upload this package[1]?
> [1] https://mentors.debian.net/package/osmose-emulator

I'm confused about the two bugs you're closing with d/changelog, as you
have marked them as fixed already in the bts. Can you please fix the
meta-data and properly use "fixed" as in described in the documentation
for the bug tracking system? Also, it completly unclear for me, whether #868499
is fixed or not. Please be more verbose in your changelogs…

Same for the other bugi (#844779). It is marked as closed in 1.2-1, so
why is it closed again? (also here, please make the information

- Usually, is is not common to update copyright years on otherwise
  unchanged files (it is only noise in the review and it makes reviews

src/Joystick.cpp and src/SoundThread.cpp: Are you sure about the #pragma
GCC diagnostic ignored "-Wstringop-truncation"? Is it really a false

About the changelogs: Usually you should not describge what you have
done (this is obvious when looking at the diff), but explain why you
have done it. For example, "update d/watch" is not really explaining why
this was necessary. 

Please make the debian bts consistent, then I will take another look at
your package.


> Thanks!
> -- 
> ⢀⣴⠾⠻⢶⣦⠀ Carlos Donizete Froes [a.k.a coringao]
> ⣾⠁⢠⠒⠀⣿⡁ - https://wiki.debian.org/coringao
> ⢿⡄⠘⠷⠚⠋⠀ GPG: 4096R/B638B780
> ⠈⠳⣄⠀⠀⠀   2157 630B D441 A775 BEFF  D35F FA63 ADA6 B638 B780

Attachment: signature.asc
Description: PGP signature

Reply to: