[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#821260: RFS: python-adventure/1.4-1 [ITP]

Am 17.04.2016 um 05:58 schrieb Ben Finney:
> Package: sponsorship-requests
> Severity: wishlist
> Howdy,
> I am looking for a sponsor for my package ‘python-adventure’.

Hi Ben,

I had a look at your package and wanted to give you some feedback
because of the effort you put into packaging this game.


The vim comments at the bottom are not allowed (syntax-wise)
CC-BY-2.0 is not a DFSG-free license, if possible better use CC-BY-3.0
or CC-BY-4.0

There are a lot of form feed characters (^L) in various debian files
which I would remove.

You have patched the upstream sources (12 patches). In general the
patches look O.K but I wonder if they are all necessary. Did you forward
them upstream? Why do you think Debian should diverge from upstream?

You split the game into three arch:all binary packages. I'm not totally
convinced that this is really necessary for a game like
python-adventure. Your current approach is not totally wrong either,
perhaps a bit too perfectionist though. Are there strong reasons why you
split the game into three parts?

Why don't you join the Python or Games Team and maintain
python-adventure within one of these teams?

I found the following things with check-all-the-things:

colossal-cave-adventure.desktop: found with desktop-file-validate
error: value "adventure;advent;colossal;cave;spelunk" for locale string
list key "Keywords" in group "Desktop Entry" does not have a semicolon
(';') as trailing character

codespell --quiet-level=3
./adventure/advent.dat:996: KNIVE  ==> KNIFE
./adventure/advent.dat:1462: THRU  ==> THROUGH

Might be intentional since it's the original game dialogue.

pep8 --ignore W191 . found something that could be improved. Nothing
critical but it could be forwarded upstream.

pyflakes3 .
./adventure/__main__.py:10: 'readline' imported but unused



Attachment: signature.asc
Description: OpenPGP digital signature

Reply to: