[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: jumpnbump



Hi Fabian,

On Sat, 2014-09-20 at 18:53 +0200, Fabian Greffrath wrote:
> Hi Tobias,
> 
> Am Samstag, den 20.09.2014, 17:43 +0200 schrieb Tobias Frost: 
> > I saw that you were looking for an sponsor for jumpnbump.
> > Well, it does not build under a pbuilder enviroment:
> > main.c:33:19: fatal error: bzlib.h: No such file or directory
> >  #include "bzlib.h"
> 
> oh, indeed, I missed to add the appropriate Build-Depends.
> 
> Thank you very much for pointing this out!
> 
> - Fabian

Its great that you take care of this package! So many thanks for your
contribution. 

The package is fine, so I will upload it just after I've sent this mail.

However, let me give you feedback / wishes / suggestions for subsequent
uploads:

-> d/FAQ need some overhaul, as http://jumpbump.mine.nu/ seems gone.

-> You might want to check  
http://web.archive.org/web/20080223114414/http://www.jumpbump.mine.nu/port/
.. it has a 1.55 tar.gz. (Maybe it makes sense to diff this source if
there is something useful in it... ; I didnt check contents)

-> you should send your patches upstream and document that in the dep3
headers.

-> in d/copyright, please remove the trailing "," after the years.
(Its not actually wrong, but I think a "," implies that there is
something to follow; if you disagree, you can keep the comma.)

Example:
write this
  2014  Fabian Greffrath <fabian+debian@greffrath.com>
instead of
  2014, Fabian Greffrath <fabian+debian@greffrath.com>

-> Please consider also to maintain jumpnbump-levels; It could have use
of some modernization and has currently no uploader ... (I'll sponsor
that too)

--
tobi

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: