Re: One last WorldForge project library
Hey Juhani,
On 10/15/2014 03:36 AM, Juhani Numminen wrote:
Here are my comments (I looked at the version in git). I hope you find
them useful.
Thanks for the great feedback!
d/control:79
interactivly download and update game data and artwork.
^
There’s a typo: interactively.
Ah, yeah. Fixed.
d/rules:4
dh $@ --parallel --with autoreconf --with python2
The addons can be listed like this: --with autoreconf,python2
Good point, that is simpler.
I think xz is the default compression, so these lines (in d/rules)
aren’t necessary:
override_dh_builddeb:
dh_builddeb -- -Zxz
Oh, you're right! I hadn't realized that the default had changed. I took
this suggestion for the pending cyphesis package as well.
“[Moving] wfut binary install to /usr/games to comply with FHS” is
better(?) achieved by passing --bindir to configure rather than using
dh_install to move the file when installing, i.e.:
1) Add this to rules:
override_dh_auto_configure:
dh_auto_configure -- --bindir=/usr/games
2) Change the first line of wfut.install to “usr/games/*”.
Hmmm. Yes, that's probably a cleaner way of going about things. Updated.
(and in cyphesis)
The VCS-Browser doesn’t work. This is what worked for me:
https://anonscm.debian.org/cgit/pkg-games/libwfut.git
Hmm, looks like I dropped the "c" from the URL. Mine was still working
for me but yours brings up all of the proper site elements. Definitely
better.
Are the patches forwarded upstream? It should be documented as DEP-3
patch header.
You're right, they should be. Just did that.
I’ve merged the two bugs #734231 “libwfut: use dh-autoreconf to fix
FTBFS on ppc64el” and #765231 “libwfut: run dh-autoreconf to update for
new architectures” so they both will be closed when the package enters
the archive with Closes: 734231.
There was a second bug? Oh, I see it was just reported a couple days
ago. Thanks for catching that!
I appreciate you taking such a close look, thanks again!
-Olek
Reply to: