[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Help with menu item? (was: gnurobots progress)



> Hi,
> 
> On Sun, Aug 24, 2014 at 04:26:54PM +0100, Iain R. Learmonth wrote:
> > I've pushed some commits to git on alioth:
> >   http://anonscm.debian.org/cgit/pkg-games/gnurobots.git
> 
> I'm not sure about the menu item I've added. It doesn't consistently show up
> when I'm testing.
> 
> The debian/menu file is based on the Debian packaging manual[1]. Is there
> another source I should have been looking at?
> 

Hi I can see that your menu entry is properly installed. Unfortunately
I do not have a menu in my WM, so I cannot check it visually. 

One thing you could also add is a desktop menu entry, so gnurobots
will be accessible from XDG menus too. You can check how it is done in
my package [1]. Adding desktop file is one on jessie debian games team
release goals [2] 

Another thing is that your patch lacks a description, you should add
it and fix all lintian warning, even if they are pedantic. 

I: gnurobots source: quilt-patch-missing-description 03_allow_to_set_cflags.patch
P: gnurobots: copyright-refers-to-symlink-license usr/share/common-licenses/GPL


[1] http://anonscm.debian.org/cgit/pkg-games/penguin-command.git/tree/debian
[2] https://wiki.debian.org/Games/JessieReleaseGoal

-- 
Dariusz Dwornikowski, 
  Institute of Computing Science, Poznań University of Technology
  www.cs.put.poznan.pl/ddwornikowski/  
  room 2.7.2 BTiCW | tel. +48 61 665 29 41

Attachment: signature.asc
Description: Digital signature


Reply to: