Re: Fwd: RFS: powder/117-2 ITA

[Steven Hamilton <oz@scorch.net>]

>> 1.  In debian/watch, you should mangle the debian version to remove the dfsg.  Look an man(1) uscan
>> for examples of how to do that.
>
> Noted. I'll work on this next.
>
>> 2.  Why do you have a clean: target instead of just using override_dh_clean: ?  It also seems very
>> strange to me that you are removing .h and .cpp files.
>
> Changed to override. These .h .cpp files are dynamically generated
> during build time to suit the platform being built for. They have to be
> removed during the clean process. Hence the override with the weird
> looking deletions.
>
>> 3.  In debian/rules it is probably easier to just import buildflags. (Actually I think dh 9+ does
>> this for you?)  Look at:  http://wiki.debian.org/HardeningWalkthrough
>
> Doesn't work. Not all of the needed buildflags are imported and they
> also don't pass to the build script. I tried lots of different way of
> doing this and the current effort proved the cleanest.
>
>> 4.  Because you are using source format 3.0 quilt, you don't need to
>> build depend on the quilt package.
>
> Removed.
>
>> 5.  debian/copyright seems to be missing copyright and license for mt19937ar.c.
>
> Copyright file reworked.
>
>> Other than that, the package seems to build and run fine.
>
> Great, I'll get on with that watch file next.

Hi All,
I've now completed work on this package. All the above issues have been
resolved. It's lintian and pbuilder clean. I'd like to seek a final
review and/or sponsorship.

P.S. It appears I've chosen an excellent package to get started with
Debian. It's present lots of various issues from a non-standard build
system, foreign system files, and out of date previous package amongst
others. I've learnt a lot and would like to thank Pabs, Barry and others
in helping me along.

-- 
Steven Hamilton
I don't look like two zombies