On Sat, Sep 14, 2013 at 12:32:08PM +0200, Markus Koschany wrote:
> Sure. Please go ahead. And please don't forget to fix
Wow! So soon? :)
A couple of comments, if you want.
Redarging debian/changelog, as I had already uploaded 1.3.1-1 to the archive, we should need to ad a newer entry (1.3.1-2) and put the changes there. This can easily be done with the command dch, or adding it by hand if you prefer.
pink-pony now depends on pink-pony-data, and that is okay, it is how it should be. Another good idea would be to recommend pink-pony from pink-pony-data (not depend, we don't want cyclical dependencies). Also, as the versions of pink-pony <= 1.3.1-1 (old ones) will include the data, pink-pony-data should conflict with them in debian/control too.
Last thing should be to add the switch -a to the commands in binary-arch: and duplicate them with the switch -i in binary-indep:. When the package is built in the builders, it won't be calling debian/rules binary, but debian/rules binary-arch for every arch-dependent architecture and once to debian/rules binary-indep for the arch-independent ones.