Re: Bug#718323: RFS: hyperrogue/3.7+dfsg-1 [ITP] -- non-euclidean graphical rogue-like game
On Tue, Jul 30, 2013 at 10:23 AM, chrysn wrote:
> i've written a package for the hyperrogue game, and would like to ask
> for sponsorship for this new package.
Here is a first-pass review:
About the fonts stuff; The best would be if the program used SDL Pango
instead or as an alternative to SDL TTF. Other font rendering systems
that automatically discover system fonts and cope with multi-script
strings by falling back on other fonts are also OK. If upstream isn't
OK with switching to SDL Pango, please send them a patch to use
fontconfig to detect where the font files are located, falling back on
runtime or compile-time configured fonts. An example of how to do this
stuff is in chromium-bsu, which uses different rendering libs but the
principles are the same. The GLC backend is an example of the SDL
Pango style and the FTGL backend is an example of the SDL TTF style.
Why is -O3 in CXXFLAGS? I would suggest sticking to the Debian default
which is set by dpkg-buildflags (-O2) and not setting CXXFLAGS in the
Makefile.
Please forward the remaining patches, manual page and desktop file
upstream if you haven't already.
Please add --parallel to the dh arguments.
You may want to run wrap-and-sort -sa.
Please use imagemagick or similar at build time to create PNG and XPM
icons (for the Freedesktop and Debian menus) from the upstream MS
Windows icon. The XPM should be 32x32 and the PNG one should be the
maximum size available in the MS Windows icon.
The copyright years in debian/copyright are slightly wrong.
Could you ask upstream; What is the origin of the numbers in
polygons.cpp? Were they created by hand? Were they converted from some
other format and hard-coded into the file? Are they maintained in some
other format? Are they not maintained at all?
Automated checks:
https://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package
lintian:
P: hyperrogue: no-upstream-changelog
blhc:
CXXFLAGS missing (-fPIE): g++ hyper.cpp -o hyper -lSDL -lSDL_ttf -DFHS
-Wall -g -lSDL_gfx -g -O2 -fstack-protector --param=ssp-buffer-size=4
-Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -Wl,-z,relro
LDFLAGS missing (-fPIE -pie -Wl,-z,now): g++ hyper.cpp -o hyper -lSDL
-lSDL_ttf -DFHS -Wall -g -lSDL_gfx -g -O2 -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Werror=format-security
-D_FORTIFY_SOURCE=2 -Wl,-z,relro
bfbtester:
Lots and lots and lots of core dumps due to SIGABRT.
desktop-file-validate:
debian/hyperrogue.desktop: error: value
"hyperbolic;escher;noneuclidean" for locale string list key "Keywords"
in group "Desktop Entry" does not have a semicolon (';') as trailing
character
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: