[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#696899: can anybody sponsor an ITP for premake4 ?

I've uploaded a new version with the changes suggested by Jonathan to mentors.

On 4 April 2013 08:01, Cameron Hart <cameron.hart@gmail.com> wrote:
Replying to Jonathan's original message since it covered most things.

On 3 April 2013 21:47, Jonathan Dowland <jmtd@debian.org> wrote:
> A quick look - sorry for the terse feedback. I don't know much about cdbs which
> limits my ability to review it very well.
>   • the changelog targets unstable, but should target experimental if you
>     want an upload prior to wheezy's release

From the discussion in the other messages it sounds like unstable is
OK for a new package?

>   • Personally in the prior-to-first-upload stage I think it's better to
>     not have multiple versions for each package revision, i.e., continually
>     create 4.3-1 versions with a single changelog entry, and to use the
>     versions only to distinguish instances of the package uploaded to the
>     main archive.

This wasn't all that clear in the docs I read, but what you are saying
makes sense. Now the trouble is I'm not sure how to get rid of the
4.3-2 version that's on mentors. I can delete the premake4 mentors
page which seems like it's probably the way to go, but makes me
slightly nervous. Can anyone advise on how to best remove the 4.3-2

>   • is the double colon in the rules file some kind of cdbs thing?

Yes. I don't know about the internals of cdbs but the build failed without it.

>   • the source package contains debian/stamp-makefile-check

I've removed this

>   • rename-changelog.diff: this is the wrong approach to rename a file.
>     Move it in the debian/rules file instead (after dh_installdocs would
>     be run. I don't know much about cdbs so not sure which rule to override)

As pointed out by Vincent, this is no longer used. I've removed the file.

I haven't uploaded my changes yet, I thought I'd wait and see if
anyone can advise me on removing the 4.3-2 version.

Reply to: