Fwd: (AssaultCube) [ actiongame-Patches-3430223 ] [Debian] Link to X11 in build
Forwarding discussion for patch sent to upstream AssaultCube bugtracker:
>> Subject: [ actiongame-Patches-3430223 ] [Debian] Link to X11 in build
>> Date: Mon, 07 Nov 2011 10:36:54 -0800
>> Patches item #3430223, was opened at 2011-10-29 16:14
>> Submitted By: Arand (arand-2)
>> Assigned to: Nobody/Anonymous (nobody)
>> Summary: [Debian] Link to X11 in build
>>
>> Initial Comment:
>> This patch ensures linking to X11, which fixes a (rare?) build failure:
>>
>> g++ -O3 -fomit-frame-pointer -Wall -fsigned-char -rdynamic -o
>> ac_client crypto.o audiomanager.o client.o clientgame.o clients2c.o
>> command.o console.o docs.o editing.o entities.o i18n.o log.o main.o
>> menus.o oggstream.o openal.o packetqueue.o physics.o protocol.o
>> rendercubes.o rendergl.o renderhud.o rendermodel.o renderparticles.o
>> rendertext.o rndmap.o scoreboard.o serverms.o server.o serverbrowser.o
>> shadow.o sound.o soundlocation.o soundscheduler.o stream.o texture.o
>> tools.o water.o weapon.o wizard.o world.o worldio.o worldlight.o
>> worldocull.o worldrender.o zip.o bot/bot.o bot/botmanager.o
>> bot/bot_ai.o bot/bot_util.o bot/bot_waypoint.o bot/ac_bot.o
>> bot/ac_bot_ai.o -L../enet/.libs -lenet -L/usr/lib64 `sdl-config
>> --libs` -lSDL_image -lz -lGL -lopenal -lvorbisfile
>> /usr/bin/ld: console.o: undefined reference to symbol 'XFree'
>> /usr/bin/ld: note: 'XFree' is defined in DSO /usr/lib64/libX11.so.6 so
>> try adding it to the linker command line
>> /usr/lib64/libX11.so.6: could not read symbols: Invalid operation
>> collect2: ld returned 1 exit status
>> make[1]: *** [client] Error 1
>> make[1]: Leaving directory `/tmp/buildd/assaultcube-1.1.0.4repack1/source/src'
>>
>
> Comment By: sireus (sireus)
> Date: 2011-11-07 10:36
>
> Message:
> This sounds more like a problem with your SDL installation. IIRC X11 should
> be linked in throug `sdl-config --libs`.
> Before I apply that patch to SVN, I'd like to know if it's actually a
> problem that should be fixed on AC's side, and if it might break things for
> other people (unlikely though).
Goneri, since it was you who reported the build failure and supplied the
fix[1], was sdl working properly as above when you experienced this? Can
you still reproduce it?
I can't myself reproduce your error, neither on squeeze, nor in a
current sid pbuilder, hence why I'm asking, since I'm not sure myself
the patch is needed.
Was it just a pbuilder fluke?
[1] http://lists.debian.org/debian-devel-games/2011/05/msg00057.html
--
Martin Werner ("arand")
Reply to: