Re: Review request for current packaging of Red Eclipse (upstream release imminent)
The Cube 2 engine is also used by Sauerbraten. Both games should share
the same engine.
You might want to run wrap-and-sort -s.
cube2font-dbg doesn't really need to give that much duplicated detail.
There is an extra space in debian/watch
cube2font doesn't appear to be compiled with -g, which is needed for
debug symbols?
I'm not sure if every package should have a README.Debian explaining
how to get a backtrace from gdb.
The quilt stuff in redeclipse/debian/README.source is not needed for
dpkg-source v3 packages.
It is possible to use wildcards in debian/*install files, for example:
usr/share/icons/hicolor/*/apps/redeclipse.png
Please explain the technical reasons for that upstream prefers to embed enet.
Please get the patches, manual pages and desktop file included upstream.
redeclipse needs to go to contrib if redeclipse-data will be going to non-free.
non-free packages need to state why they are non-free in debian/copyright:
http://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile
Some files appear to be not distributable:
Files: src/site/bits/redeclipse-large.png src/site/bits/redeclipse-regular.png
src/site/bits/redeclipse-small.png src/site/bits/relogo*
src/site/bits/sprite.png src/site/bits/wallpaper*
data/textures/bloodbath.png data/textures/carnage.png
data/textures/critical.png data/textures/dominate.png
data/textures/firstblood.png data/textures/headshot.png
data/textures/massacre.png data/textures/multi.png
data/textures/revenge.png data/textures/slaughter.png
data/textures/triple.png
data/textures/logo.png data/luckystrike/pub2* data/luckystrike/pub1*
License: Akashi-Font
Files: data/particles/smoke.png data/particles/explosion.png
data/textures/lava.jpg
License:
Created by RaZgRiZ Made with Filter Forge II Beta 3
Licensed publicly for everyone to use and modify as long as the author is
credited for the original work.
Files: data/particles/blood.png
License:
Created by FischKopF, source: http://www.quadropolis.us/node/2693
"Feel free to edit, claim it's yours, use it in own projects"
Files: forest*.ogg cycadas.ogg
License:
Provided that you mention (somewhere, somehow) that the original samples are
archived at freesound.org you are granted permission to modify/use, even
commercially. It's the only prerequisite I impose.
.
Furthermore, providing a link to the original samples at freesound may be
helpful to other developers, but this is just a personal opinion, not a
prerequisite.
.
The original samples are archived at freesound.org, specifically:
http://www.freesound.org/samplesViewSingle.php?id=34580
http://www.freesound.org/samplesViewSingle.php?id=7292
Comment:
Special permission for relicensing under above license have been granted by
the author.
You are missing the copyright/license for the embedded JavaScript code
copies in redeclipse-data.
data/models/actors/turret, data/models/weapons/plasma,
data/models/weapons/flamer, are under CC-BY-SA-3.0-AU not regular
CC-BY-SA.
Similarly ./data/torley/ is the USA version of CC-BY-SA. It also has a
weird no selling clause.
Some of the files have no known filetype (according to file(1)) or are
gzip compressed but the data inside that has no known filetype. Could
you get them included in file if appropriate? Some of the text-based
formats could probably use adding to file too. Also, do we have tools
to create/modify them in Debian?
The comments in some of the audio files point at this software, I
guess the audio is one of the things we don't have source for?
http://www.image-line.com/documents/edison.html
https://en.wikipedia.org/wiki/Cool_Edit
ogginfo -q claims that some of the Ogg files are corrupted (holes).
Some of the readme.txt files say that source .psd files are available
on the author's website.
There are a small number of duplicate files in the data package, you
might want to inform upstream about that.
dpkg-shlibdeps: warning: dependency on libstdc++.so.6 could be avoided
if "debian/cube2font/usr/bin/cube2font" were not uselessly linked
against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libz.so.1 could be avoided if
"debian/cube2font/usr/bin/cube2font" were not uselessly linked against
it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libgcc_s.so.1 could be avoided
if "debian/cube2font/usr/bin/cube2font" were not uselessly linked
against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libgcc_s.so.1 could be avoided
if "debian/redeclipse/usr/lib/games/redeclipse/redeclipse" were not
uselessly linked against it (they use none of its symbols).
dpkg-shlibdeps: warning: dependency on libgcc_s.so.1 could be avoided
if "debian/redeclipse-server/usr/lib/games/redeclipse/redeclipse-server"
were not uselessly linked against it
dpkg-gencontrol: warning: Depends field of package cube2font-dbg:
unknown substitution variable ${shlibs:Depends}
dpkg-gencontrol: warning: Depends field of package redeclipse-dbg:
unknown substitution variable ${shlibs:Depends}
dpkg-gencontrol: warning: Depends field of package
redeclipse-server-dbg: unknown substitution variable ${shlibs:Depends}
P: cube2font source: unversioned-copyright-format-uri
http://dep.debian.net/deps/dep5/
P: cube2font-dbg: no-upstream-changelog
P: cube2font: no-upstream-changelog
P: redeclipse source: unversioned-copyright-format-uri
http://dep.debian.net/deps/dep5/
I: redeclipse-server-dbg: extended-description-is-probably-too-short
I: redeclipse-dbg: extended-description-is-probably-too-short
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: