[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS / R to join

On Sat, Apr 17, 2010 at 04:32:53PM +0800, Paul Wise wrote:
> On Sat, Apr 17, 2010 at 1:11 AM, Josue Abarca <jmaslibre@debian.org.gt> wrote:
> > http://mentors.debian.net/debian/pool/main/g/greed/greed_3.4-3.dsc
> A review:

Hello Paul, thanks for the review.

> You forgot to close the ITA in the changelog.
> No need to include the author's name in the package description,
> usually we
> Please get the relevant patches included upstream. Makefile.diff is
> definitely appropriate to send upstream.

Ok, I sent the 3 patches, He acepted the first, I am waiting for his
answer about the other two.

> If you intend to maintain greed in the games team, we generally put
> the team address (pkg-games-devel) in the Maintainer and the primary
> team member doing the work in Uploaders.

> debian/README.Debian mentions xbomb, probably that is a mistake.

> You can remove the boilerplate text at the start of debian/rules

> Your email in Makefile.diff is missing the .gt TLD.

> #437088 should be trivial to fix, please do so and send any patch upstream.

> When you contact upstream, please point them at the following URLs,
> found with 'whohas greed':

> I'd also suggest that upstream switch from a plain Makefile to
> autotools so that all the install paths etc are configurable at build
> time and CFLAGS/etc are customisable.


> gcc warnings to send upstream (preferrably with patch):
Patched and sent to upstreamer.

> lintian complaint:
> P: greed: no-upstream-changelog
> You might want to suggest to upstream that they create one.


Please if you have time, check the package again.
Thanks a lot for your help.


Also, I sent a "Request to join" to the pkg-games in Alioth a week
ago, so I am waiting the answer to start using the pkg-games git repo

Josué M. Abarca S.
Vos mereces Software Libre.
PGP key 4096R/70D8FB2A 2009-06-17
fingerprint = B3ED 4984 F65A 9AE0 6511  DAF4 756B EB4B 70D8 FB2A

Attachment: signature.asc
Description: Digital signature

Reply to: