Re: RFS / R to join
On Sat, Apr 17, 2010 at 1:11 AM, Josue Abarca <jmaslibre@debian.org.gt> wrote:
> http://mentors.debian.net/debian/pool/main/g/greed/greed_3.4-3.dsc
A review:
You forgot to close the ITA in the changelog.
No need to include the author's name in the package description, usually we
Please get the relevant patches included upstream. Makefile.diff is
definitely appropriate to send upstream.
If you intend to maintain greed in the games team, we generally put
the team address (pkg-games-devel) in the Maintainer and the primary
team member doing the work in Uploaders.
debian/README.Debian mentions xbomb, probably that is a mistake.
You can remove the boilerplate text at the start of debian/rules
Your email in Makefile.diff is missing the .gt TLD.
#437088 should be trivial to fix, please do so and send any patch upstream.
When you contact upstream, please point them at the following URLs,
found with 'whohas greed':
http://bugs.debian.org/src:greed
http://www.freebsd.org/cgi/cvsweb.cgi/ports/games/greed/files/patch-greed.c?rev=1.1
http://trac.macports.org/browser/trunk/dports/games/greed/Portfile
(contains sed-based patches)
http://cvsweb.se.netbsd.org/cgi-bin/bsdweb.cgi/pkgsrc/games/greed/patches/patch-ab?rev=1.2
http://cvsweb.se.netbsd.org/cgi-bin/bsdweb.cgi/pkgsrc/games/greed/patches/patch-aa?rev=1.3
I'd also suggest that upstream switch from a plain Makefile to
autotools so that all the install paths etc are configurable at build
time and CFLAGS/etc are customisable.
gcc warnings to send upstream (preferrably with patch):
greed.c:168: warning: incompatible implicit declaration of built-in
function ‘exit’
greed.c: In function ‘out’:
greed.c:176: warning: incompatible implicit declaration of built-in
function ‘exit’
greed.c: In function ‘usage’:
greed.c:183: warning: incompatible implicit declaration of built-in
function ‘exit’
greed.c: In function ‘main’:
greed.c:212: warning: incompatible implicit declaration of built-in
function ‘strlen’
greed.c:215: warning: incompatible implicit declaration of built-in
function ‘exit’
greed.c:328: warning: incompatible implicit declaration of built-in
function ‘exit’
greed.c: In function ‘topscores’:
greed.c:547: warning: incompatible implicit declaration of built-in
function ‘malloc’
greed.c:579: warning: incompatible implicit declaration of built-in
function ‘exit’
greed.c:607: warning: incompatible implicit declaration of built-in
function ‘strncpy’
greed.c: In function ‘lockit’:
greed.c:681: warning: incompatible implicit declaration of built-in
function ‘exit’
lintian complaint:
P: greed: no-upstream-changelog
You might want to suggest to upstream that they create one.
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: