[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#680583: desktop-base: please demote librsvg2-common to Recommends:



severity 680583 normal
tags 680583 - patch
kthxbye

Two things off the bat:

it's not a major effect of the usability -- most installs will find
librsvg2-common on the system anyway, and it's only a few megs of space.
Most ARM machines I have have at least 4 gigs of space, and I'd not worry
too much about stuff like this.

I understand an unneeded dep is annoying and can cause problems, but I
don't see the 'important' severity. If you're that crunched, kill off
desktop-base entirely -- it's just themes ;)

I'm happy to change it back if you can justify it ;)

Secondly, while you did include a changelog update, you forgot to
include the control file update -- please re-send with an attached patch
+ fix the control tags :)

After we get an ACK (read more below), i'll happily apply it.

On Fri, Jul 06, 2012 at 06:10:45PM -0600, Luca Capello wrote:
> Package: desktop-base
> Version: 6.0.5squeeze1
> Severity: important
> Tags: patch
> User: events@debian.org
> Usertags: events-hardware
> 
> Hi there!
> 
> While working on BabelBox [1], I discovered that desktop-base Depends:
> on librsvg2-common:
> 
> --8<---------------cut here---------------start------------->8---
>  desktop-base (4.0.0.1) experimental; urgency=high
> [...]
>    [ Loic Minier ]
>    * Depend on librsvg2-common for SVG support.
> 
>  -- Gustavo Franco <stratus@debian.org>  Tue, 30 Jan 2007 17:08:41 -0200 
> --8<---------------cut here---------------end--------------->8---
> 
> [1] <http://lists.debian.org/87liiyruwj.fsf@gismo.pca.it>
> 
> However, so far I have failed to understand what "SVG support" means,
> given that it does not seems to be needed at all and actually it brings
> a lot of (useless) dependencies:

It appears it's 60 or so megs unpacked, it's a few, but not a lot IMHO.

> =====
> # apt-get update
> [...]
> Reading package lists... Done
> # apt-get install desktop-base
> [...]
> The following NEW packages will be installed:
>   dbus defoma desktop-base fontconfig hicolor-icon-theme libatk1.0-0
>   libatk1.0-data libavahi-client3 libavahi-common-data libavahi-common3
>   libcairo2 libcroco3 libcups2 libdatrie1 libdbus-1-3 libfont-freetype-perl
>   libglib2.0-0 libglib2.0-data libgsf-1-114 libgsf-1-common libgtk2.0-0
>   libgtk2.0-bin libgtk2.0-common libjasper1 libjpeg62 libpango1.0-0
>   libpango1.0-common libpng12-0 librsvg2-2 librsvg2-common libthai-data
>   libthai0 libtiff4 libxcb-render-util0 libxcb-render0 libxcomposite1
>   libxcursor1 libxrandr2 shared-mime-info x-ttcidfont-conf
> 0 upgraded, 40 newly installed, 0 to remove and 0 not upgraded.
> Need to get 24.0 MB of archives.
> After this operation, 62.6 MB of additional disk space will be used.
> Do you want to continue [Y/n]? n
> Abort.
> # apt-get --no-install-recommends install desktop-base
> [...]
> The following NEW packages will be installed:
>   defoma desktop-base fontconfig libatk1.0-0 libavahi-client3
>   libavahi-common-data libavahi-common3 libcairo2 libcroco3 libcups2
>   libdatrie1 libdbus-1-3 libglib2.0-0 libgsf-1-114 libgsf-1-common libgtk2.0-0
>   libgtk2.0-common libjasper1 libjpeg62 libpango1.0-0 libpango1.0-common
>   libpng12-0 librsvg2-2 librsvg2-common libthai-data libthai0 libtiff4
>   libxcb-render-util0 libxcb-render0 libxcomposite1 libxcursor1 libxrandr2
>   shared-mime-info
> 0 upgraded, 33 newly installed, 0 to remove and 0 not upgraded.
> Need to get 22.1 MB of archives.
> After this operation, 53.4 MB of additional disk space will be used.
> Do you want to continue [Y/n]? n
> Abort.
> # apt-get --download-only install destkop-base
> [...]
> Download complete and in download only mode
> # dpkg --force-all -i /var/cache/apt/archives/ desktop-base_6.0.5squeeze1_all.deb 
> [..]
> Unpacking desktop-base (from .../desktop-base_6.0.5squeeze1_all.deb) ...
> dpkg: desktop-base: dependency problems, but configuring anyway as you requested:
>  desktop-base depends on librsvg2-common; however:
>   Package librsvg2-common is not installed.
> Setting up desktop-base (6.0.5squeeze1) ...
> 
> Configuration file `/etc/default/kdm.d/10_desktop-base', does not exist on system.
> Installing new config file as you requested.
> update-alternatives: using /usr/share/images/desktop-base/spacefun-wallpaper.svg to provide /usr/share/images/desktop-base/desktop-background (desktop-background) in auto mode.
> update-alternatives: using /usr/share/images/desktop-base/spacefun-splash.svg to provide /usr/share/images/desktop-base/desktop-splash (desktop-splash) in auto mode.
> update-alternatives: using /usr/share/images/desktop-base/spacefun-grub.png to provide /usr/share/images/desktop-base/desktop-grub.png (desktop-grub) in auto mode.
> Generating grub.cfg ...
> Found background image: /usr/share/images/desktop-base/desktop-grub.png
> Found linux image: /boot/vmlinuz-2.6.32-5-amd64
> Found initrd image: /boot/initrd.img-2.6.32-5-amd64
> done
> update-initramfs: deferring update (trigger activated)
> Processing triggers for initramfs-tools ...
> update-initramfs: Generating /boot/initrd.img-2.6.32-5-amd64
> # 
> =====
> 
> At reboot, GRUB2 shows the SpaceFun theme.  The same is true for wheezy:
> desktop-base *installs* fine without librsvg2-common.  IMHO this

That might be the case, but it appears to be a runtime thing, we need to
be careful not to needlessly klobber something, desktop-base is a pretty
monolithic package to begin with, so making judgements like this is
always a bit tricky.

> dependency should be reflected by those packages *using* SVG files, not
> by desktop-base, which only ships them:

What an interesting report, thank you! (Also, SpaceFun is no longer the
default in Wheezy, I suggest you update ;) )

The interesting part is this - librsvg2-common provides SVG rendering
for GTK+ applications, which appears to be included as a Depends: on GDM
(although not KDM, because I'm guessing it has it's own special sauce
for Qt / SVG)

I'm willing to entertain this change, but I'd much rather know why it
was added in the first place. I'd hate to reintroduce a bug (esp post
freeze).

It's only a few megs, but I understand the concern.

I've CC'd lool to see if he remembers anything about this situation.

> 
> --8<---------------cut here---------------start------------->8---
> Index: changelog
> ===================================================================
> --- changelog	(revision 294)
> +++ changelog	(working copy)
> @@ -5,8 +5,12 @@
>    * Fix typo in plymouth theme. (Closes: #679357)
>    * Updated ink-splated kde wallpaper, to fix alignment issues.
>  
> - -- Eshat Cakar <info@eshat.de>  Wed, 27 Jun 2012 22:08:35 +0200
> +  [ Luca Capello ]
> +  * debian/control:
> +    + demote librsvg2-common to Recommends (Closes: #NNNNNN).
>  
> + --
> +
>  desktop-base (7.0.0) unstable; urgency=low
>  
>    [ Eshat Cakar ]
> --8<---------------cut here---------------end--------------->8---

And thanks for this, as well!

> 
> Thx, bye,
> Gismo / Luca
> 
> -- System Information:
> Debian Release: 6.0.5
>   APT prefers stable
>   APT policy: (500, 'stable')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 2.6.32-5-amd64 (SMP w/1 CPU core)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> 
> Versions of packages desktop-base depends on:
> pn  librsvg2-common               <none>     (no description available)
> 
> desktop-base recommends no packages.
> 
> Versions of packages desktop-base suggests:
> pn  gnome | kde-standard | xfce4  <none>     (no description available)
> 
> -- no debconf information

Thanks!
 Paul

-- 
 .''`.  Paul Tagliamonte <paultag@debian.org>
: :'  : Proud Debian Developer
`. `'`  4096R / 8F04 9AD8 2C92 066C 7352  D28A 7B58 5B30 807C 2A87
 `-     http://people.debian.org/~paultag

Attachment: signature.asc
Description: Digital signature


Reply to: