[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#607458: desktop-base: debian/copyright file is outdated



On Sat, 18 Dec 2010 19:51:17 +0100 Yves-Alexis Perez wrote:

> On sam., 2010-12-18 at 18:15 +0100, Francesco Poli (t1000) wrote:
[...]
> > However, the changes needed to fix that bug do not seem to
> > be properly documented in the debian/copyright file, unfortunately.
> 
> What do you mean?

I just mean that the fix changed some parts of the package, but those
changes (and also some previous changes, I would say) were not properly
reflected in the debian/copyright file...

> > 
> > It seems to me that this file is rather outdated and in need of
> > a complete review and update.
> 
> There was a review and update recently, which I guess you miss. Might
> not be complete though.

My bug report was based on
http://packages.debian.org/changelogs/pool/main/d/desktop-base/desktop-base_6.0.4/desktop-base.copyright
which I think is the version currently in sid...

> 
> 
> > Some random checks highlight at least the following issues:
> > 
> >  * the debian-background.svg file seems to be no longer present
> >    in the package (that's a relief, since it was apparently
> >    derived from the non-free DOUL-with)
> 
> Thanks, dropped.

Good!   :-)

> >  
> >  * there does not seem to be any clear copyright notice
> >    (with years and copyright holders) and license for
> >    debian-security.xcf, which is derived from the DOUL
> >    (under the Expat/MIT license) and from a GNOME icon
> >    (under which license?!?)
> 
> “created” and “updated” looks to me like pretty clear, though years are
> missing. Will ping initial author to get some information.

Good idea: I hope he can clarify this (especially the license of the
used GNOME icon!).

> > 
> >  * the debian-official-logo-small.png image seems to be no longer
> >    present (that's a relief, since the official logo is non-free)
> 
> Thanks, dropped.

You're welcome!

> > 
> >  * there does not seem to be any clear copyright notice
> >    (with years and copyright holders) and license for
> >    the gnome-debian-sid "kit", which is (now) derived from
> >    at least the DOUL (under the Expat/MIT license)
> 
> I'll let Josselin add this.

Fair enough.

> > 
> >  * the SpaceFun theme copyright notice and license does not seem to be
> >    complete, since it does not mention that the theme was derived from
> >    the DOUL (which is copyright (c) 1999 Software in the Public
> >    Interest and released under the Expat/MIT license, a license
> >    which is distinct from the GPLv2, even though compatible with it)
> 
> Added.

Please note that the DOUL is the Debian Open Use Logo without “Debian”
and its license is the Expat/MIT license. The attached patch (against
http://svn.debian.org/wsvn/debian-desktop/packages/trunk/desktop-base/debian/copyright?rev=232&sc=1)
should fix this.

> > 
> >  * I cannot see any information about the nightly and moreblue-orbit
> >    themes ...
> 
> Added.

Good!

> >  
> >  * I cannot find any information about the emblem-debian.icon and
> >    emblem-debian.png files ...
> > 
> Either.

Mmmmh, so this is still to be fixed...

> 
> > I really hope the debian/copyright file may be fixed in time
> > for the squeeze release.
> 
> Again, bugs don't magically fix themselves, so reporting is nice (and
> useful) but providing patches is better.

Of course: make no mistake, I am trying to help as much as I possibly
can!

> 
> Regards,

Have a nice night.

-- 
 http://www.inventati.org/frx/frx-gpg-key-transition-2010.txt
 New GnuPG key, see the transition document!
..................................................... Francesco Poli .
 GnuPG key fpr == CA01 1147 9CD2 EFDF FB82  3925 3E1C 27E1 1F69 BFFE
diff -ruN rev232/copyright rev232patched/copyright
--- rev232/copyright	2010-12-18 23:11:26.000000000 +0100
+++ rev232patched/copyright	2010-12-18 23:30:25.000000000 +0100
@@ -3,21 +3,33 @@
 
 This package is comprised of bits and pieces from various sources.
 
-The Debian â??open useâ?? logo is used in various bits of artwork:
+The Debian Open Use Logo without â??Debianâ?? is used in various bits of artwork:
 
     Copyright (c) 1999 Software in the Public Interest
- 
-    This logo or a modified version may be used by anyone to refer to
-    the Debian project, but does not indicate endorsement by the
-    project.
 
-    Note: we would appreciate that you make the image a link to
-    http://www.debian.org/ if you use it on a web page.
+    Permission is hereby granted, free of charge, to any person obtaining
+    a copy of this software and associated documentation files (the
+    "Software"), to deal in the Software without restriction, including
+    without limitation the rights to use, copy, modify, merge, publish,
+    distribute, sublicense, and/or sell copies of the Software, and to
+    permit persons to whom the Software is furnished to do so, subject to
+    the following conditions:
+
+    The above copyright notice and this permission notice shall be included
+    in all copies or substantial portions of the Software.
+
+    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+    OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+    MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+    IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+    CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+    TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+    SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. 
 
 The  debian-security.xcf  file  (and  the resulting  .png  file)  was created
 by Colin Walters <walters@debian.org>  and updated by Ulrich Hansen
-<uhansen@mainz-online.de>. They are based on the Debian Open Use Logo and a
-GNOME icon
+<uhansen@mainz-online.de>. They are based on the Debian Open Use Logo
+without â??Debianâ?? and a GNOME icon.
 
 The .desktop  files included  in this package  were compiled  by Colin
 Walters <walters@debian.org>.
@@ -39,7 +51,7 @@
 Spacefun plymouth theme is © 2010 Aurelien Couderc and released under the GPLv3
 license, using artwork from Valessio S. Brito.
 
-They both includes the Debian â??open useâ?? logo.
+They both include the Debian Open Use Logo without â??Debianâ??.
 
 Nightly theme (nightly-splash.png, nightly-wallpaper.png and nightly.xml) is ©
 2008 Robert Jähne and released under the GPLv2.

Attachment: pgpSsZ3wfJbuy.pgp
Description: PGP signature


Reply to: