[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#503566: leftover /etc/splashy/themes breaks upgrade of desktop-base



Just wanted to report a me-too on this bug, to give some indication that
the problem does affect more than one installation.

I got this on upgrade of desktop-base from 5.0.1 to 5.0.3:

obelix:/etc# apt-get dist-upgrade
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Calculating upgrade... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
1 not fully installed or removed.
After this operation, 0B of additional disk space will be used.
Do you want to continue [Y/n]? 
Setting up desktop-base (5.0.3) ...
>Set theme as: moreblue-orbit          [ FAIL ]
dpkg: error processing desktop-base (--configure):
 subprocess post-installation script returned error exit status 1
Errors were encountered while processing:
 desktop-base
E: Sub-process /usr/bin/dpkg returned an error code (1)


The immediate reason seems to be that I've got a /etc/splashy/themes
directory without the moreblue-orbit theme:

bjorn@obelix:~$ ls -l /etc/splashy/themes/
total 36
drwxr-xr-x 2 root root 4096 2007-08-10 10:42 crux
drwxr-xr-x 2 root root 4096 2007-08-10 10:42 debian3
drwxr-xr-x 2 root root 4096 2007-08-10 10:42 debian4
drwxr-xr-x 2 root root 4096 2007-08-10 10:42 debian-cubism
drwxr-xr-x 2 root root 4096 2007-08-10 10:42 debian-moreblue
drwxr-xr-x 2 root root 4096 2007-08-10 10:42 debiansplashy
drwxr-xr-x 2 root root 4096 2007-08-10 10:28 default
drwxr-xr-x 2 root root 4096 2007-08-10 10:42 kubuntusplashy
drwxr-xr-x 2 root root 4096 2007-08-10 10:42 ubuntusplashy

I don't know how I ended up with this.  The transition from /etc/splashy
to /usr/share/splashy has obviously failed at some point:


bjorn@obelix:~$ ls -l /etc/splashy
total 8
-rw-r--r--  1 root root  550 2008-10-09 11:02 config.xml
drwxr-xr-x 11 root root 4096 2008-12-20 13:37 themes

bjorn@obelix:~$ ls -l /usr/share/splashy/themes/
total 8
drwxr-xr-x 2 root root 4096 2008-11-01 13:18 default
drwxr-xr-x 2 root root 4096 2008-12-20 13:37 moreblue-orbit


But I still think that the desktop-base.postinst script is too touchy
abouth this.  Is a failing splashy installation really important?  Why
not simply ignore it?  There seems to be a number of installations where
it otherwise will make desktop-base upgrades fail. I'm including a
suggested patch.


Attachment: pgpFFON_GLmf1.pgp
Description: PGP signature

--- desktop-base.postinst.orig	2008-12-14 23:18:24.000000000 +0100
+++ desktop-base.postinst	2008-12-21 13:04:08.000000000 +0100
@@ -97,7 +97,7 @@
     fi
 
     if [ -x /sbin/splashy_config ] && [ -w /etc/splashy/config.xml ]; then
-        splashy_config --set-theme moreblue-orbit
+        splashy_config --set-theme moreblue-orbit || true
     fi
 
     if [ -x /usr/sbin/update-initramfs ]; then


Bjorn

Reply to: