Bug#1090056: search.cgi links to wrong bug.css
On Sun, Dec 15, 2024 at 03:21:06PM -0800, Don Armstrong wrote:
> On Sun, 15 Dec 2024, Bill Allombert wrote:n
> > Package: debbugs
> > Version: 2.6.3
> > Severity: normal
> >
> > Hello Don,
> >
> > This is from #644242.
> >
> > the file cgi/search.cgi links to http://bugs.debian.org/css/bugs.css instead
> > of linking to $gWebHostBugDir/css/bugs.css or maybe /$gWebHostBugDir/css/bugs.css
I like to fix the issue of $gWebHostBugDir vs /$gWebHostBugDir
This is all the instances where $gWebHostBugDir is referenced (without duplicate)
./scripts/text: <LINK REL=\"stylesheet\" HREF=\"$gWebHostBugDir/css/bugs.css\" TYPE=\"text/css\">
./scripts/config.in.default:$gWebHostBugDir = "";
./cgi/pkgreport.cgi: qq(<link rel="stylesheet" href="$gWebHostBugDir/css/bugs.css" type="text/css">) .
./examples/config:$gWebHostBugDir = "Bugs"; # e.g. Bugs
./examples/config:$gWebDomain = "$gWebHost/$gWebHostBugDir";
./examples/config.debian:$gWebHostBugDir = "";
./UPGRADE.md:$gWebHostBugDir = "Bugs"; # e.g. Bugs
./UPGRADE.md:$gWebDomain = "$gWebHost/$gWebHostBugDir";
So there are two cases: debian
$gWebHostBugDir = "";
in that case the css is in /css/bugs.css, an absolute location
default:
$gWebHostBugDir = "Bugs";
in that case the css is in Bugs/bugs.css, an relative location
I have avoided this issue by setting $gWebHostBugDir to "/Bugs".
I do not if this is intended. Maybe there is a better way.
> That's a reasonable change. However, there's an underlying issue here:
> the search system is based on hyper estraier which is no longer
> supported upstream (or in Debian).
Note that this is the subject of a separate bug report, #1071657.
> You might consider stopping the distribution of it in the package until
> that code is in place.
Does debbugs itself still use search.cgi ? If not, search.cgi can be moved to examples.
Cheers,
--
Bill. <ballombe@debian.org>
Imagine a large red swirl here.
Reply to: