[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#622934: marked as done (local-debbugs: missing newline at end of "'/etc/debbugs/config' doesn't exist" message)

Your message dated Sun, 15 Dec 2024 22:55:26 +0100
with message-id <Z19QTh8J_B6XRtK0@seventeen>
and subject line Re: Bug#622934: local-debbugs: missing newline at end of "'/etc/debbugs/config' doesn't exist" message
has caused the Debian Bug report #622934,
regarding local-debbugs: missing newline at end of "'/etc/debbugs/config' doesn't exist" message
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
622934: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=622934
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libdebbugs-perl
Version: 2.4.2~exp1
Severity: minor
Justification: cosmetic
Tags: patch

Hi,

Trying local-debbugs again.  How about this patch?

-- 8< --
Subject: Add missing newline to (! -e $conf_file) message

The message reporting that /etc/debbugs/config doesn't exist is
missing a trailing newline.  Noticed because it runs into the
next message when trying out debbugs-local for the first time.

 $ local-debbugs --mirror
 configuration file '/etc/debbugs/config' doesn't exist; skipping itRsyncing bugs
 [...]

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 Debbugs/Config.pm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Debbugs/Config.pm b/Debbugs/Config.pm
index ae4c04f..d5a928d 100644
--- a/Debbugs/Config.pm
+++ b/Debbugs/Config.pm
@@ -1025,7 +1025,7 @@ set_default(\%config,'html_expire_note',
 sub read_config{
      my ($conf_file) = @_;
      if (not -e $conf_file) {
-	 print STDERR "configuration file '$conf_file' doesn't exist; skipping it";
+	 print STDERR "configuration file '$conf_file' doesn't exist; skipping it\n";
 	 return;
      }
      # first, figure out what type of file we're reading in.
-- 
1.7.5.rc2

--- End Message ---
--- Begin Message --- 
Version: 2.6.0

On Fri, Apr 15, 2011 at 06:11:53PM -0500, Jonathan Nieder wrote:
> Package: libdebbugs-perl
> Version: 2.4.2~exp1
> Severity: minor
> Justification: cosmetic
> Tags: patch
> 
> Hi,
> 
> Trying local-debbugs again.  How about this patch?
> 
>  sub read_config{
>       my ($conf_file) = @_;
>       if (not -e $conf_file) {
> -	 print STDERR "configuration file '$conf_file' doesn't exist; skipping it";
> +	 print STDERR "configuration file '$conf_file' doesn't exist; skipping it\n";
>  	 return;
>       }
>       # first, figure out what type of file we're reading in.

Hello Jonathan,

This was fixed in 2.6.0 in this commit

commit 621ee75bb7ca185b1d428fa606d5d31c44c19e0d
Author: Don Armstrong <don@donarmstrong.com>
Date:   Tue Jan 17 22:16:06 2012 -0800

    test for equality, and only complain about the conffile missing if debug is set

Cheers,
-- 
Bill. <ballombe@debian.org>

Imagine a large red swirl here.

--- End Message ---
Reply to: