[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Add SIG_SUBPACKET as a known_keyword.

I can work on adding that enhancement to the patch and resubmit. As soon as I'm back online at home I'll start looking into it.

-- Sent from my Palm Pre

On Apr 20, 2010 18:07, Torsten Werner <twerner@debian.org> wrote:

Hi Jeremy,

we have evaluated your patch again and found some issues:
<http://tools.ietf.org/html/rfc4880#section-5.2.3> explains:

An implementation SHOULD ignore any subpacket of a type that it does
not recognize.

Bit 7 of the subpacket type is the "critical" bit. If set, it
denotes that the subpacket is one that is critical for the evaluator
of the signature to recognize. If a subpacket is encountered that is
marked critical but is unknown to the evaluating software, the
evaluator SHOULD consider the signature to be in error.

Your patch should be enhanced to reject signatures with subpackets
that have the 'critical' bit 7 set. All other subpackets can be
ignored. Do you want to work on that?


Reply to: