Re: Bug#1110345: lomiri-location-service FTCBFS: Multiple reasons

[Helmut Grohne <helmut@subdivi.de>]

Hi Nilesh,

On Mon, Aug 04, 2025 at 08:23:27PM +0530, Nilesh Patra wrote:
> Hmm -- is it? That's news. I did find several packages using !nocheck build profile
> when I searched on codesearch.debian.net _including_ the final lomiri package [1].

Probably, most of
https://codesearch.debian.net/search?q=Build-Profiles%3A.*nocheck&literal=0
are buggy and should be fixed.

> And the test-only deps seem to be marked with !nocheck as well.

If the package is normally reproducible and nocheck produces something
else (e.g. fewer packages), that's an rc bug in forky. Refer to glib2.0
for a sensible example installing tests into a binary package.

> Should that be fixed in the lomiri package too, in that case?

Yes.

> > ifeq (,$(filter lomiri-location-service-doc,$(shell dh_listpackages)))
> > 
> > If doing an arch-only build or a nodoc build, debhelper will not list
> > the package in dh_listpackages.
> > 
> > > +EXTRA_CMAKE_OPTS += -DBUILD_DOCS=OFF
> > > +endif
> > > +ifneq (,$(findstring nocheck, $(DEB_BUILD_OPTIONS) $(DEB_BUILD_PROFILES)))
> > 
> > This should likely be matching noinsttest.
> 
> I do not see that option for DEB_BUILD_OPTIONS on the debian policy doc [2]
> and lintian still suggests nocheck [3].

noinsttest is a build profile only. nocheck is an option and profile and
eventually we'd like to turn it into a profile only. So once you move to
noinsttest, you should be matching DEB_BUILD_PROFILES only. Last but not
least, use filter instead of findstring. The profile pkg.foo.noinsttest
should not be matched, but findstring would match it.

Helmut