Re: Bug#1110345: lomiri-location-service FTCBFS: Multiple reasons
On 04/08/25 11:21, Helmut Grohne wrote:
On Mon, Aug 04, 2025 at 12:54:25AM +0530, Nilesh Patra wrote:
2. The lomiri-location-service-tests package misses a !nocheck build profile due
to which cross-builds were trying to build for test package as well
<!nocheck> generally should never be used in Build-Profiles to disable
the building of certain packages. To inhibit the building of installed
tests, please use the noinsttest build profile.
That may mean that some of the Build-Depends must move their <!nocheck>
annotations to <!noinsttest> annotations. Since that profile is not
enabled by default for cross builds, that may result in failing to
satisfy cross build depends.
Hmm -- is it? That's news. I did find several packages using !nocheck build profile
when I searched on codesearch.debian.net _including_ the final lomiri package [1].
And the test-only deps seem to be marked with !nocheck as well.
Should that be fixed in the lomiri package too, in that case?
export DPKG_GENSYMBOLS_CHECK_LEVEL=4
+EXTRA_CMAKE_OPTS =
include /usr/share/dpkg/default.mk
+ifneq (,$(findstring nodoc, $(DEB_BUILD_OPTIONS) $(DEB_BUILD_PROFILES)))
There is a lomiri-location-service-doc package. Do you happen to know
whether BUILD_DOCS affects other packages beyond this?
Before submitting the patch, I skimmed over the relevant files and also
checked the resulting .deb and it seemed to me that it does not.
I'll try to double-check later.
ifeq (,$(filter lomiri-location-service-doc,$(shell dh_listpackages)))
If doing an arch-only build or a nodoc build, debhelper will not list
the package in dh_listpackages.
+EXTRA_CMAKE_OPTS += -DBUILD_DOCS=OFF
+endif
+ifneq (,$(findstring nocheck, $(DEB_BUILD_OPTIONS) $(DEB_BUILD_PROFILES)))
This should likely be matching noinsttest.
I do not see that option for DEB_BUILD_OPTIONS on the debian policy doc [2]
and lintian still suggests nocheck [3].
Am I the only one getting confused? :P
Should this be noinsttest for DEB_BUILD_PROFILES and nocheck for DEB_BUILD_OPTIONS?
[1] https://sources.debian.org/src/lomiri/0.5.0-4/debian/control/?hl=237#L237
[2] https://www.debian.org/doc/debian-policy/ch-source.html#debian-rules-and-deb-build-options:
[3] https://lintian.debian.org/tags/override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS.html
Reply to: