Re: subread -- Request for review
On Thu, Mar 11, 2021 at 01:38:16PM +0100, Helmut Grohne wrote:
> Hi Nilesh,
>
> On Thu, Mar 11, 2021 at 05:48:54PM +0530, Nilesh Patra wrote:
> > --- /dev/null
> > +++ b/debian/patches/cross.patch
> > @@ -0,0 +1,121 @@
> > +--- a/src/Makefile.Linux
> > ++++ b/src/Makefile.Linux
> > +@@ -1,7 +1,7 @@
> > + #MACOS = -D MACOS
> > +
> > +
> > +-CC_EXEC = gcc
> > ++CC ?= gcc
>
> Your assignment is a noop, because CC has a default value of "cc".
I see, removed it then
> > --- a/debian/rules
> > +++ b/debian/rules
> > @@ -24,7 +24,7 @@ endif
> > dh $@
> >
> > override_dh_clean:
> > - cd src; make -f Makefile.Linux clean
> > + cd src && rm -f core featureCounts exactSNP removeDup subread-buildindex
>
> What's the purpose of this change?
wouldn't "make -f Makefile.Linux" cause problems for cross building?
(Hardcoding on make?)
I rather copied the clean instruction here -- Do I miss something?
> > override_dh_auto_build:
> > - cd src; make -f Makefile.Linux
> > - dh_auto_build -- CC=$(CC)
> > + dh_auto_build --sourcedirectory=src -- -f Makefile.Linux CC=$(CC)
>
> When the Makefile is not detected by dh_auto_build, I recommend
> explicitly passing --buildsystem=makefile.
I'm not sure if I understand you there. It has several Makefiles in
"src/", by default it will take in Makefile for compiling, which we do
not want hence forcing it to use Makefile.Linux
Do you instead mean passing in it in any case, something like?:
dh $@ --buildsystem=makefile
Nilesh
Reply to: