Re: subread -- Request for review
Hi Nilesh,
On Thu, Mar 11, 2021 at 05:48:54PM +0530, Nilesh Patra wrote:
> --- /dev/null
> +++ b/debian/patches/cross.patch
> @@ -0,0 +1,121 @@
> +--- a/src/Makefile.Linux
> ++++ b/src/Makefile.Linux
> +@@ -1,7 +1,7 @@
> + #MACOS = -D MACOS
> +
> +
> +-CC_EXEC = gcc
> ++CC ?= gcc
Your assignment is a noop, because CC has a default value of "cc".
> --- a/debian/rules
> +++ b/debian/rules
> @@ -24,7 +24,7 @@ endif
> dh $@
>
> override_dh_clean:
> - cd src; make -f Makefile.Linux clean
> + cd src && rm -f core featureCounts exactSNP removeDup subread-buildindex
What's the purpose of this change?
> override_dh_auto_build:
> - cd src; make -f Makefile.Linux
> - dh_auto_build -- CC=$(CC)
> + dh_auto_build --sourcedirectory=src -- -f Makefile.Linux CC=$(CC)
When the Makefile is not detected by dh_auto_build, I recommend
explicitly passing --buildsystem=makefile.
Helmut
Reply to: