[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Request for review] fsm-lite



Hi Helmut,

On Wed, Mar 10, 2021 at 12:22:15PM +0100, Helmut Grohne wrote:
> Hi Nilesh,
> 
> On Wed, Mar 10, 2021 at 04:40:02PM +0530, Nilesh Patra wrote:
> > I'm not very sure if simply replacing DEB_BUILD_ARCH by DEB_HOST_ARCH could be a better solution(I'm tempted to assume so ;-)), hence
> > any review is really appreciated
> 
> Yes, this is the right solution. If you simply drop the option for cross
> builds, a cross build to amd64 will differ from a native build on amd64.
> You'd make the build unreproducible.

Yes, got it. I was wondering the same, thanks for confirming

> However, I think that -msse4.2 also is an architecture baseline
> violation. Please file an rc bug immediately. Refer to
> https://wiki.debian.org/ArchitectureSpecificsMemo for details. This
> rc-bug is required even if you can fix it with a direct upload, because
> you cannot transition the package to testing without an unblock and you
> cannot unblock without a fixed rc bug.

Looks like it is a violation. Do you think building on amd64 for every
optimization, i.e. sse4.2 down to the point there's no vectorization a
good way to go about it?
To make it more clear, I'd simply like pointing you to here[1] for
example, and the build for amd64 being built in for every optimization.
Please let me know.

I also asked on debian-med@l.d.o, and waiting for an ack/reply just for
reference[2]

[1]: https://salsa.debian.org/med-team/rna-star/-/blob/master/debian/rules#L13
[2]: https://lists.debian.org/debian-med/2021/03/msg00065.html

Nilesh


Reply to: