[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

RFS: cl-launch (updated package)

Hi Far?

Am Mittwoch, den 22.07.2015, 00:55 -0400 schrieb Far?:
> Dear Debian Mentors and Debian Lispers,
> I am looking for a sponsor for the new version 4.1.4-1
> of my package "cl-launch".
> It builds these binary packages:
> cl-launch  - uniform frontend to running Common Lisp code from the 
> shell
> The package appears to be lintian clean.
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/c/cl-launch
> - Source repository: deb-src http://mentors.debian.net/debian unstabl
> e
> main contrib non-free
>  - dget http://mentors.debian.net/debian/pool/main/c/cl-launch/cl
> -launch_4.1.4-1.dsc
> I would be glad if someone uploaded this package for me.
> Kind regards,
> ??? ? Fran?ois-Ren? ?VB Rideau ?Reflection&Cybernethics? 
> http://fare.tunes.org
> Do not handicap your children by making their lives easy. ? Robert 
> Heinlein

Here's a review, but incomplete as I only have a few minutes.
(Maybe someone jumps in as well)

I see that your package has several DDs a uploaders. I'm wondering why
they don't upload it for you, if they co-maintain the package?

Did you file an RFS-Bug?

In d/changelog, there are many versions that where never in Debian,
also it reads more like an upstream changelog than an Debian changelog.
On the other side, changes to debian/* are not explained. (e.g the fact
and the resons why to update all the versions of the dependencies in
d/control). Refer to the Policy about d/changelog.

d/compat is 7, mind to upgrade the package to compat level 9?

d/cl-launch.1 The manpage says "generated with Ronn/v0.7.3".
If it is autogenerated, it needs to be done at build time.

You do not have a VCS-Browser tag
About your layout: It is not recommended to have the debian directory
in your master branch, as you cannot independently work on those.
Think of NMUs and how you would be able to integrate such changes in
your repository? (I suggest to put the debian packaging into its own
This is also the point where I point people to 
https://wiki.debian.org/UpstreamGuide, if they are upstream and
maintainer at the same time.

d/rules could be transformed to short debhelper format.

(note: did not check alls details in d/copyright, so just a few things
I saw at first glance)
- The bugroff license text is missing.
- Copyright years are not up to date

Ok, have to go now.



Reply to: